Review main Merged

64901[BUGFIX] Show indexed_search backend module on PostgreSQL for pages with subpages

Stephan Großberndt CR +2 V +2 Easy +1 −1 updated 07/25/20, 16:31

Commit message

This patch fixes the SQL query retrieving the statistics in the
indexed_search backend module for pages containing subpages when
using PostgreSQL by making sure the IN clause only contains a plain
int array instead of a multidimensional one (which MySQl appears to
cope with without issues surprisingly).

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Stephan Großberndt uploaded patch set 1 06/16/20, 16:10

  2. TYPO3com voted on patch set 1 V -1 06/16/20, 16:24 Completed build in 13m 47s on Tue, 16 Jun, 04:24 PM Test Summary: 4 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3927

  3. Stephan Großberndt wrote 06/16/20, 17:19

    Topic set to postgresql
  4. TYPO3com voted on patch set 1 V +1 06/16/20, 17:40 Completed build in 1h 43m 36s on Tue, 16 Jun, 05:40 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3927

  5. Oliver Klee voted on patch set 1 CR +1 07/10/20, 17:34

  6. Daniel Goerz commented on patch set 1 V +1 CR +1 07/24/20, 09:43

    Verified that it still works on MySQL
  7. Anja Leichsenring voted on patch set 1 V +2 CR +2 07/25/20, 16:31

  8. Anja Leichsenring merged patch set 2 07/25/20, 16:31