64902[BUGFIX] Avoid SQL error in indexed_search indexer on PostgreSQL
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 912
-
Stephan Großberndt uploaded patch set 1 06/16/20, 17:17
-
Stephan Großberndt wrote 06/16/20, 17:18
Topic set to postgresql -
TYPO3com voted on patch set 1 V -1 06/16/20, 17:32 Completed build in 15m 07s on Tue, 16 Jun, 05:32 PM Test Summary: 14 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3930
-
TYPO3com voted on patch set 1 V +1 06/16/20, 18:25 Completed build in 1h 23m 22s on Tue, 16 Jun, 06:25 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3930
-
Oliver Klee commented on patch set 1 CR -1 06/17/20, 11:52
Indexer.php:1955According to https://www.php.net/manual/de/function.round.php , round still returns a float. So you'll need to add an int cast (or replace the round with the cast). -
Stephan Großberndt uploaded patch set 2 06/17/20, 12:33
-
Stephan Großberndt commented on patch set 2 06/17/20, 12:36
Indexer.php:1955ReplyIt works with round() too though as the relevant part is the returned number not having any places after the decimal point. -
TYPO3com voted on patch set 2 V +1 06/17/20, 12:51 Completed build in 18m 11s on Wed, 17 Jun, 12:51 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3938
-
Oliver Klee voted on patch set 2 CR +1 07/10/20, 17:35
-
Georg Ringer voted on patch set 2 V +1 CR +1 07/13/20, 18:04
-
Benni Mack voted on patch set 2 V +2 CR +2 07/15/20, 09:47
-
Benni Mack wrote 07/15/20, 09:47
Change has been successfully rebased and submitted as 1b85129391c55eb72c1b98ff7b673de2707b9e7d by Benni Mack