Review main Merged

64904[BUGFIX] Fetch TYPO3 version in reports module only

Markus Klein CR +2 V +2 Normal +2 −97 updated 08/04/20, 15:01

Commit message

The core version check is run synchronously while logging
into the Backend. If the get.typo3.org service is down,
logins take extremely long.

Since there is no API to run this check asynchronously,
the patch drops this information from the toolbar,
it is only available in the reports module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 3443

Show 1218 earlier messages
  1. Markus Klein uploaded patch set 1 06/17/20, 13:49

  2. Benni Mack commented on patch set 1 06/17/20, 14:00

    I'd rather store this information in sys_registry once per day and recheck once per day, or once per week. What do you think?
  3. Markus Klein commented on patch set 1 06/17/20, 14:00

    > Patch Set 1: > > I'd rather store this information in sys_registry once per day and recheck once per day, or once per week. What do you think? I like!
  4. TYPO3com voted on patch set 1 V +1 06/17/20, 14:02 Completed build in 12m 32s on Wed, 17 Jun, 02:02 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3940

  5. Markus Klein commented on patch set 1 CR -1 06/17/20, 14:08

    going for Benni's idea
  6. Markus Klein uploaded patch set 2 06/17/20, 14:53

  7. TYPO3com voted on patch set 2 V -1 06/17/20, 14:53 Completed build in 24s on Wed, 17 Jun, 02:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3942

  8. Markus Klein uploaded patch set 3 06/17/20, 14:55

  9. Markus Klein updated the commit message in patch set 4 06/17/20, 14:58

  10. TYPO3com voted on patch set 3 V -1 06/17/20, 15:08 Completed build in 12m 44s on Wed, 17 Jun, 03:08 PM Test Summary: 1169 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3943

  11. TYPO3com voted on patch set 4 V -1 06/17/20, 15:14 Completed build in 16m 20s on Wed, 17 Jun, 03:14 PM Test Summary: 981 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3944

  12. Oliver Hader commented on patch set 4 CR -1 06/17/20, 15:51

    I'd suggest to completely remove this feature since * the server-side implementation uses a blocking request (problematic for endpoint failures, DNS failures, ...) → in this particular use-case it should be a client request (AJAX, not exposing server's static IP address) * retrieving data should be opt-in (due to recent discussions at https://decisions.typo3.org/t/disable-external-requests-until-opted-in-by-admin/593) * there is more potential with collecting anonymous usage data (opted-in) - however we need to restructure the whole architecture a lot That's why my feeling is, that it's not worth the efforts here and simpler for the time being to drop this feature completely.
  13. Markus Klein uploaded patch set 5 06/17/20, 16:08

  14. TYPO3com voted on patch set 5 V -1 06/17/20, 16:09 Completed build in 27s on Wed, 17 Jun, 04:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3945

  15. Markus Klein commented on patch set 6 06/17/20, 18:56

    Published edit on patch set 5.
  16. TYPO3com voted on patch set 6 V +1 06/17/20, 19:08 Completed build in 12m 01s on Wed, 17 Jun, 07:08 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3946

  17. Simon Gilli voted on patch set 6 CR +1 06/18/20, 00:28

  18. Helmut Hummel commented on patch set 6 06/18/20, 16:56

    CoreVersionService.php:183

    how about using a cache instead of the registry?
  1. Markus Klein commented on patch set 6 06/18/20, 18:07

    CoreVersionService.php:183 Reply

    The main reason from my POV is that caches are flushed "regularly". This information is IMO nothing you should be able to flush away, but should be maintained by the system. On top caches store temporary information, whereas this version information is not temporary, but persistent and just gets updated from time to time.
  2. Stefan Neufeind commented on patch set 6 CR +1 06/20/20, 10:25

    CoreVersionService.php:183 Reply

    I'm with Markur here. If we're worried about the size, maybe the information returned from the API could be boiled down before storing it in the registry?
  3. Simon Gilli commented on patch set 6 06/20/20, 17:13

    CoreVersionService.php:183 Reply Unresolved

    fyi about the sizes: currently there are 913, 469 and 470 bytes downloaded from the server, I guess the size in the registry is less. Afais one value of each array is used only so this could be minimized much by deleting not used values before saving.
  4. Andreas Kienast voted on patch set 6 V +1 CR +1 06/26/20, 11:29

  5. Daniel Goerz commented on patch set 6 06/29/20, 17:23

    CoreVersionService.php:186

    Do we want to use the DateTimeAspect instead of calling time() 3 times?
  6. Markus Klein commented on patch set 6 06/29/20, 17:33

    CoreVersionService.php:186 Reply

    Do we have it in all contexts?
  7. Daniel Goerz commented on patch set 6 06/29/20, 17:58

    CoreVersionService.php:186 Reply Unresolved

    Yes. $GLOBALS['EXEC_TIME'] would also be an option.
  8. Daniel Goerz uploaded patch set 7 07/20/20, 18:02

  9. Daniel Goerz voted on patch set 7 V +1 CR +1 07/20/20, 18:05

  10. TYPO3com voted on patch set 7 V +1 07/20/20, 18:14 Completed build in 11m 58s on Mon, 20 Jul, 06:14 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4164

  11. Simon Gilli voted on patch set 7 CR +1 07/24/20, 14:25

  12. Benni Mack commented on patch set 7 07/27/20, 21:21

    sorry, late to the game, but how about we remove the "Typo3VersionMessage" class (Event Listener) to not fetch the information for the toolbar but in the reports and install tool (in addition to the 24hs change that the latest patch includes)?
  13. Markus Klein commented on patch set 7 07/28/20, 09:27

    Any solution is welcome. Mine is/was just a suggestion.
  14. Benni Mack uploaded patch set 8 07/28/20, 14:53

  15. TYPO3com voted on patch set 8 V +1 07/28/20, 15:04 Completed build in 11m 24s on Tue, 28 Jul, 03:04 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4285

  16. Simon Gilli voted on patch set 8 V +1 CR +1 07/28/20, 18:52

  17. Christian Kuhn commented on patch set 8 08/04/20, 11:35

    Hey. Sorry for being late at the party ;) I'm all in for dropping the version info from the toolbar in all maintained core versions. Left are then the reports and the install tool. For both I don't think a 24h cache is benefitial: Suppose someone clicks on reports module, then an hour later the "core security update, please upgrade" mail comes in, user clicks on reports module and it still shows "current version, all good", due to the cache. User will have to wait 23 more hours to receive correct info. This scenario is worse for the install tool core version updater. I would thus suggest to only drop the toolbar info, but keep 'current' info in reports module and install tool. This will solve the initial 'get.typo3.org down -> backend login takes ages' issue, and only the reports module would be slow if actively clicked by a user. The install tool updater would fail anyway if get.typo3.org is down, so that shouldn't be an issue in the first place. I can happily push a new patch set with that solution if you aggree :)
  18. Markus Klein commented on patch set 8 08/04/20, 11:43

    > Patch Set 8: > > Hey. Sorry for being late at the party ;) > > I'm all in for dropping the version info from the toolbar in all maintained core versions. > > Left are then the reports and the install tool. For both I don't think a 24h cache is benefitial: Suppose someone clicks on reports module, then an hour later the "core security update, please upgrade" mail comes in, user clicks on reports module and it still shows "current version, all good", due to the cache. User will have to wait 23 more hours to receive correct info. This scenario is worse for the install tool core version updater. > > I would thus suggest to only drop the toolbar info, but keep 'current' info in reports module and install tool. This will solve the initial 'get.typo3.org down -> backend login takes ages' issue, and only the reports module would be slow if actively clicked by a user. The install tool updater would fail anyway if get.typo3.org is down, so that shouldn't be an issue in the first place. > > I can happily push a new patch set with that solution if you aggree :) Go!
  19. Christian Kuhn commented on patch set 8 CR -1 08/04/20, 11:50

    Thanks for feedback. I'll push an update soon.
  20. Christian Kuhn uploaded patch set 9 08/04/20, 12:10

  21. TYPO3com voted on patch set 9 V +1 08/04/20, 12:22 Completed build in 12m 18s on Tue, 4 Aug, 12:22 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4398

  22. Christian Kuhn voted on patch set 9 V +1 CR +1 08/04/20, 12:24

  23. Simon Gilli voted on patch set 9 V +1 CR +1 08/04/20, 14:44

  24. Benni Mack voted on patch set 9 V +2 CR +2 08/04/20, 15:01

  25. Benni Mack merged patch set 10 08/04/20, 15:01