64905[WIP][BUGFIX] Avoid using NodeList.prototype.forEach directly
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 33
- Build/Sources/TypeScript/adminpanel/Resources/Public/TypeScript/Modules/Cache.ts+2 −0
- Build/Sources/TypeScript/adminpanel/Resources/Public/TypeScript/AdminPanel.ts+2 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/AbstractSortableSelectItems.ts+1 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectMultipleSideBySideElement.ts+1 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Login.ts+1 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/NewContentElementWizard.ts+1 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageActions.ts1+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Utility.ts+2 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/BackwardCompat/NodeListPolyfill.tsnew+38 −0
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/Grid.ts+1 −0
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/WidgetContentCollector.ts+1 −0
- Build/Sources/TypeScript/extensionmanager/Resources/Public/TypeScript/Main.ts+1 −0
- Build/Sources/TypeScript/lowlevel/Resources/Public/TypeScript/QueryGenerator.ts+1 −0
- Build/Sources/TypeScript/scheduler/Resources/Public/TypeScript/Scheduler.ts+1 −0
- Build/Sources/TypeScript/setup/Resources/Public/TypeScript/SetupModule.ts+1 −0
- Build/Sources/TypeScript/t3editor/Resources/Public/TypeScript/T3editor.ts+1 −0
- typo3/sysext/adminpanel/Resources/Public/JavaScript/Modules/Cache.js+1 −1
- typo3/sysext/adminpanel/Resources/Public/JavaScript/AdminPanel.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/AbstractSortableSelectItems.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectMultipleSideBySideElement.js+1 −1
Show 13 more files
- typo3/sysext/backend/Resources/Public/JavaScript/Login.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/NewContentElementWizard.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageActions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Utility.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/BackwardCompat/NodeListPolyfill.jsnew+13 −0
- typo3/sysext/core/Resources/Public/JavaScript/ReferrerRefresh.js7+6 −2
- typo3/sysext/dashboard/Resources/Public/JavaScript/Grid.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetContentCollector.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js+1 −1
- typo3/sysext/lowlevel/Resources/Public/JavaScript/QueryGenerator.js+1 −1
- typo3/sysext/scheduler/Resources/Public/JavaScript/Scheduler.js+1 −1
- typo3/sysext/setup/Resources/Public/JavaScript/SetupModule.js+1 −1
- typo3/sysext/t3editor/Resources/Public/JavaScript/T3editor.js+1 −1
Review log 2835
Show 910 earlier messages
-
Felix König uploaded patch set 1 06/17/20, 14:38
-
Mathias Brodala commented on patch set 1 06/17/20, 14:41
It looks like this is something which should be added as compilation rule instead to make sure all affected locations are covered automatically.ReferrerRefresh.js:2You can still use an arrow function here which is converted according to the rules. -
Felix König commented on patch set 1 06/17/20, 14:48
> Patch Set 1: > > (1 comment) > > It looks like this is something which should be added as compilation rule instead to make sure all affected locations are covered automatically. Absolutely, yes. But this file in specific is not being processed by a bundler, whose task the transpiling would be. -
TYPO3com voted on patch set 1 V +1 06/17/20, 14:50 Completed build in 12m 39s on Wed, 17 Jun, 02:50 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3941
-
Andreas Kienast commented on patch set 1 06/18/20, 05:12
ReferrerRefresh.js:2Reply UnresolvedWhich rules? This is standalone JavaScript not being processed any further. -
Andreas Kienast commented on patch set 1 06/18/20, 05:13
Would `Array.from(document.querySelectorAll(...)).forEach()` work as well? -
Felix König commented on patch set 1 06/18/20, 06:42
> Patch Set 1: > > Would `Array.from(document.querySelectorAll(...)).forEach()` work as well? No, a console error occurs: "Das Objekt unterstützt die Eigenschaft oder Methode "from" nicht" -> The object (array) does not support the property / function "from". -
Mathias Brodala commented on patch set 1 06/18/20, 06:43
> Patch Set 1: > > > Patch Set 1: > > > > Would `Array.from(document.querySelectorAll(...)).forEach()` work as well? > > No, a console error occurs: "Das Objekt unterstützt die Eigenschaft oder Methode "from" nicht" -> The object (array) does not support the property / function "from". True: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from#Browser_compatibility -
Helmut Hummel commented on patch set 1 07/20/20, 11:37
ReferrerRefresh.js:2can't we just use document.getElementById('referrer-refresh').click();? -
Andreas Kienast commented on patch set 1 07/20/20, 16:49
ReferrerRefresh.js:2ReplyAck
-
Helmut Hummel commented on patch set 2 08/18/20, 10:24
Published edit on patch set 1. -
Helmut Hummel commented on patch set 2 08/18/20, 10:24
ReferrerRefresh.js:2ReplyWorks for us like that in a customer project since weeks now -
Helmut Hummel commented on patch set 2 08/18/20, 10:25
ReferrerRefresh.js:2ReplyDone -
Helmut Hummel voted on patch set 2 V +1 CR +1 08/18/20, 10:26
-
Helmut Hummel updated the commit message in patch set 3 08/18/20, 10:32
-
Helmut Hummel voted on patch set 3 V +1 CR +1 08/18/20, 10:32
-
TYPO3com voted on patch set 2 V +1 08/18/20, 10:36 Completed build in 11m 47s on Tue, 18 Aug, 10:36 AM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4754
-
TYPO3com voted on patch set 3 V +1 08/18/20, 10:44 Completed build in 12m 01s on Tue, 18 Aug, 10:44 AM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4755
-
Andreas Kienast commented on patch set 3 08/18/20, 11:02
ReferrerRefresh.js:1UnresolvedDo we need a safety-net in case `#referrer-refresh` cannot be found (= null)? -
Oliver Hader voted on patch set 3 CR -1 08/30/20, 16:37
-
Oliver Hader uploaded patch set 4 08/30/20, 16:43
-
Oliver Hader voted on patch set 4 CR -1 08/30/20, 16:49
-
Oliver Hader commented on patch set 4 08/30/20, 16:50
NodeList.prototype.forEach is used in a bunch of other places as well... -
TYPO3com voted on patch set 4 V +1 08/30/20, 16:55 Completed build in 10m 59s on Sun, 30 Aug, 04:55 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5064
-
Oliver Hader commented on patch set 4 08/30/20, 17:01
Instead of using `Array.from()` for the remaining occurrences, I'd opt for using a polyfill (like https://github.com/imagitama/nodelist-foreach-polyfill/blob/master/index.js) for still having the possibility to avoid these work-around calls in our source code. -
Oliver Hader commented on patch set 4 08/30/20, 19:13
Okay, taking back my previous comment... `Array.from` for work-arounds is used a lot already... -
Oliver Hader uploaded patch set 5 08/30/20, 19:32
-
Oliver Hader commented on patch set 5 08/30/20, 19:33
Back on my 1st thought, the polyfill seems to be the best option to me... -
Oliver Hader commented on patch set 5 08/30/20, 19:36
Todos (of the community) * search for occurrences, wrapping NodeList.prototype.forEach in Array.from * test the changes - ReferrerRefresh was basically the most prominent case * once ready, please remove the "[WIP]" (for work in progress) flag -
TYPO3com voted on patch set 5 V -1 08/30/20, 19:44 Completed build in 11m 21s on Sun, 30 Aug, 07:44 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5065
-
Oliver Hader uploaded patch set 6 08/30/20, 20:41
-
TYPO3com voted on patch set 6 V -1 08/30/20, 20:54 Completed build in 12m 34s on Sun, 30 Aug, 08:54 PM Test Summary: 73134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5066
-
TYPO3com voted on patch set 6 V +1 08/31/20, 08:20 Completed build in 11h 50m 38s on Mon, 31 Aug, 08:20 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5066
-
Helmut Hummel commented on patch set 6 11/30/20, 11:07
PageActions.ts:230UnresolvedforEach used but polyfill not imported? -
Benni Mack abandoned the change 11/03/21, 21:27
I will abandon this change for now, as there wasn't any feedback in over 12 months. TYPO3 v9 (IE 11 support) does not receive any patches from the community, and TYPO3 v10 has no IE 11 support anymore.