Review main Abandoned

64906[WIP][BUGFIX] Allow social images to have default processing configuration

Benni Mack CR 0 V 0 Easy +9 −8 updated 06/22/20, 09:53

Commit message

EXT:seo renders og:image and twitter:image by default using the cropping
functionality, however it is not possible to actually resize the image.

One of TYPO3's strengths is that the frontend can resize images even
though editors have uploaded a huge file (in terms of size or width), but
this does not apply yet to the MetaTagGenerator of EXT:seo.

For this reason, it is now possible to inject defaults to the "og:image" and
"twitter:image".

page.meta.defaults.og:image.maxW = 2000c

I would actually consider that TYPO3 Core should use sensible defaults by
default instead of configuring this via TypoScript (as I've done now)
to resize the images (maxW = 2000) for things generated by EXT:seo.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 23

  1. Benni Mack uploaded patch set 1 06/18/20, 09:32

  2. TYPO3com voted on patch set 1 V +1 06/18/20, 09:46 Completed build in 13m 34s on Thu, 18 Jun, 09:46 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3947

  3. Benni Mack abandoned the change 06/22/20, 09:53

    we'll use a different approach