Review main Merged

64909[BUGFIX] Add max width for social media images

Benni Mack CR +2 V +2 Easy +4 −5 updated 06/22/20, 10:23

Commit message

The og:image and twitter:image meta tags are not resized.
If an editor puts a 5000 pixel wide image in a field,
it does not get resized, and if it is large
enough (in size + MB) it doesn't get picked up everywhere.

For this reason, we'll limit the image width to 2000

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • David Steeb +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • David Steeb +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Benni Mack uploaded patch set 1 06/19/20, 14:47

  2. David Steeb commented on patch set 1 V +1 CR +1 06/19/20, 14:53

    Tested, thanks!
  3. Richard Haeser voted on patch set 1 V +1 CR +1 06/22/20, 08:51

  4. Benni Mack updated the commit message in patch set 2 06/22/20, 09:59

  5. Richard Haeser voted on patch set 2 V +1 CR +1 06/22/20, 10:01

  6. TYPO3com voted on patch set 2 V +1 06/22/20, 10:11 Completed build in 11m 43s on Mon, 22 Jun, 10:11 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3976

  7. David Steeb commented on patch set 2 V +1 CR +1 06/22/20, 10:21

    +1 Tested and verified, works on production
  8. Benni Mack voted on patch set 2 V +2 CR +2 06/22/20, 10:23

  9. Benni Mack merged patch set 3 06/22/20, 10:23