Review 10.4 Merged

64918[BUGFIX] Use hashed object identifier in IRRE for nprogress

Daniel Goerz CR +2 V +2 Easy +13 −7 updated 06/29/20, 18:21

Commit message

nprogress is used to indicate activity when a collapsed IRRE node is
about to get loaded. In case of FlexForms the id attribute may contain a
dot which is not an issue if handled correctly.
However, nprogress doesn't treat this value as an id, but rather as a
full CSS selector which causes issues and breaks loading the IRRE node.

To work around this issue, the id of the container used to render the
progress bar is now MD5 hashed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 58

  1. Daniel Goerz commented on patch set 1 06/29/20, 17:37

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js
  2. Daniel Goerz uploaded patch set 2 06/29/20, 17:42

  3. TYPO3com voted on patch set 1 V -1 06/29/20, 17:51 Completed build in 13m 23s on Mon, 29 Jun, 05:51 PM Test Summary: 12 of 74364 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-56

  4. TYPO3com voted on patch set 2 V -1 06/29/20, 17:55 Completed build in 13m 29s on Mon, 29 Jun, 05:55 PM Test Summary: 1 of 74365 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-57

  5. Daniel Goerz commented on patch set 2 06/29/20, 17:58

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V +1 06/29/20, 18:15 Completed build in 47m 15s on Mon, 29 Jun, 06:15 PM Test Summary: 73880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-57

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 06/29/20, 18:21

  8. Daniel Goerz merged patch set 3 06/29/20, 18:21