Review 10.4 Merged

64919[BUGFIX] Reinitialize PageRenderer after deserialization

Daniel Goerz CR +2 V +2 Normal +89 −7 updated 06/29/20, 19:07

Commit message

Do not swap the global singleton instance, as
that would only update new classes that are
retrived though GeneralUtlity::makeInstance).
Existing ones (cached in already initialized
classes, or initialized via the symfony DI container
would not be updated).

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 3

Files 5

Review log 56

  1. Daniel Goerz commented on patch set 1 06/29/20, 18:31

    Cherry Picked from branch master.
  2. Oliver Hader commented on patch set 1 CR -2 06/29/20, 18:41

    wait (I need to test something)
  3. TYPO3com voted on patch set 1 V +1 06/29/20, 18:45 Completed build in 13m 57s on Mon, 29 Jun, 06:45 PM Test Summary: 73878 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-60

  4. Oliver Hader voted on patch set 1 CR 0 06/29/20, 19:02

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 06/29/20, 19:07

  6. Daniel Goerz merged patch set 2 06/29/20, 19:07