Review main Merged

64932[BUGFIX] Replace $.trim with String.prototype.trim

Andreas Kienast CR +2 V +2 Easy +9 −9 updated 06/29/20, 07:49

Commit message

The JavaScript modules now utilize the native String.prototype.trim
function to trim whitespaces off string where jQuery's trim was used
before.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1012

  1. Andreas Kienast uploaded patch set 1 06/20/20, 13:43

  2. TYPO3com voted on patch set 1 V +1 06/20/20, 13:59 Completed build in 16m 32s on Sat, 20 Jun, 01:59 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3969

  3. Andreas Kienast wrote 06/27/20, 09:39

    Topic set to javascript
  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 06/27/20, 09:54

  5. Helmut Hummel voted on patch set 1 CR +1 06/27/20, 17:04

  6. Oliver Hader commented on patch set 1 06/28/20, 07:17

    Please consider that `trim` is dealing with undefined values. When for whatever reason `val()` cannot be resoled, `trim` is not defined as function. ``` $.trim($('nope').val()); ($('nope').val() || '').trim(); ```
  7. Andreas Kienast commented on patch set 1 V -1 06/28/20, 09:40

    > Patch Set 1: > > Please consider that `trim` is dealing with undefined values. When for whatever reason `val()` cannot be resoled, `trim` is not defined as function. > > ``` > $.trim($('nope').val()); > ($('nope').val() || '').trim(); > ``` Good catch, Extension Configuration is broken right now.
  8. Andreas Kienast uploaded patch set 2 06/28/20, 09:45

  9. TYPO3com voted on patch set 2 V +1 06/28/20, 09:57 Completed build in 11m 50s on Sun, 28 Jun, 09:57 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4005

  10. Markus Klein voted on patch set 2 V +1 CR +1 06/29/20, 07:26

  11. Daniel Goerz voted on patch set 2 V +2 CR +2 06/29/20, 07:49

  12. Daniel Goerz merged patch set 3 06/29/20, 07:49