Review main Merged

64933[BUGFIX] Reconfigure and update typo3/class-alias-loader

Daniel Goerz CR +2 V +2 Hard +535 −20 updated 06/26/20, 11:15

Commit message

Always loading the alias loader is required in order to
allow extensions to provide class aliases in non Composer mode.

Also update the class alias loader to latest version with:

composer up typo3/class-alias-loader

By doing so, we can remove the additional composer dumpautoload
in test suite, which only was required because the alias loader
update requires a two step operation.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 810

  1. Daniel Goerz uploaded patch set 1 06/22/20, 19:31

  2. Wouter Wolters commented on patch set 1 06/22/20, 21:48

    Can you explain why this is needed in non-composer mode. AFAIK there are no aliases anymore in TYPO3 to be loaded. Therefor I removed the complete alias loader.
  3. Helmut Hummel uploaded patch set 2 06/24/20, 09:53

  4. TYPO3com voted on patch set 2 V -1 06/24/20, 09:53 Completed build in 26s on Wed, 24 Jun, 09:53 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3978

  5. Helmut Hummel voted on patch set 2 V +1 CR +1 06/24/20, 09:53

  6. Helmut Hummel uploaded patch set 3 06/24/20, 09:54

  7. Helmut Hummel voted on patch set 3 V +1 CR +1 06/24/20, 09:55

  8. TYPO3com voted on patch set 3 V +1 06/24/20, 10:10 Completed build in 15m 43s on Wed, 24 Jun, 10:10 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3979

  9. Andreas Kienast voted on patch set 3 V +2 CR +2 06/26/20, 11:15

  10. Andreas Kienast merged patch set 4 06/26/20, 11:15