Review main Merged

64934[BUGIFX] Store state of PageTitleProviderManager in cache

Helmut Hummel CR +2 V +2 Normal +81 −3 updated 06/30/20, 16:44

Commit message

To allow uncached plugins to provide a different page title,
page title providers must be also be called after uncached plugins
are rendered. To not loose the state of page title providers
that are called for cached entires, the state of page title
providers is stored in cache as well and provided for the
second title generation process after uncached objects are rendered.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 68

  1. Helmut Hummel uploaded patch set 1 06/24/20, 16:44

  2. TYPO3com voted on patch set 1 V -1 06/24/20, 16:56 Completed build in 11m 50s on Wed, 24 Jun, 04:56 PM Test Summary: 6 of 73350 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3982

  3. Helmut Hummel uploaded patch set 2 06/25/20, 09:18

  4. TYPO3com voted on patch set 2 V +1 06/25/20, 09:29 Completed build in 11m 25s on Thu, 25 Jun, 09:29 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3986

  5. Markus Klein voted on patch set 2 CR +1 06/25/20, 10:52

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 06/29/20, 18:41

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 06/30/20, 16:44

  8. Daniel Goerz merged patch set 3 06/30/20, 16:44