Review main Abandoned

64935[FEATURE] Introduce internal notes dashboard widget

Markus Hölzle CR 0 V 0 Normal +162 −1 updated 11/08/21, 15:29

Commit message

Introduce a small dashboard widget for an overview of all
internal notes, grouped by categories.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 2125

  1. Markus Hölzle uploaded patch set 1 06/24/20, 17:40

  2. TYPO3com voted on patch set 1 V +1 06/24/20, 17:52 Completed build in 11m 41s on Wed, 24 Jun, 05:52 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3983

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 06/28/20, 07:19

  4. Anja Leichsenring commented on patch set 1 CR -1 06/28/20, 07:47

    I miss a feature rst file
  5. Anja Leichsenring uploaded patch set 2 04/27/21, 19:34

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 04/27/21, 19:35

  7. core-ci voted on patch set 2 V +1 04/27/21, 19:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10776

  8. Daniel Goerz commented on patch set 3 04/27/21, 19:50

    Published edit on patch set 2.
  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 04/27/21, 19:57

  10. Daniel Goerz commented on patch set 3 04/27/21, 19:57

    I dont see much use in this information tbh. What is the use case here?
  11. core-ci voted on patch set 3 V +1 04/27/21, 20:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10779

  12. Oliver Hader commented on patch set 3 CR -1 04/27/21, 20:06

    Let me try something...
  13. Anja Leichsenring wrote 04/27/21, 20:13

    Removed Code-Review+1 by Anja Leichsenring <aleichsenring@ab-softlab.de>
  14. Oliver Hader uploaded patch set 4 04/27/21, 20:31

  15. Oliver Hader commented on patch set 4 04/27/21, 20:36

    Just simplified the code in the data-retrieval repository. However, in general I'm wondering for which use-case this change might be useful to be part of the TYPO3 core - seems, like this is a specific scenario that might qualify for a individual extension.
  16. Oliver Hader voted on patch set 4 V +1 04/27/21, 20:36

  17. Oliver Hader voted on patch set 4 CR +1 04/27/21, 20:38

  18. core-ci voted on patch set 4 V +1 04/27/21, 20:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10786

  19. Oliver Hader voted on patch set 4 CR 0 04/27/21, 20:45

  20. Oli Bartsch commented on patch set 4 CR -1 04/27/21, 20:50

    On it
  21. Oliver Hader commented on patch set 4 V 0 CR -1 04/27/21, 20:56

    Just remembered that there was a discussion, back then when dashboards were introduced to TYPO3, pointing out that basically only common scenarios would qualify for the core. That's why I'd suggest to move this particular implementation to an own extension.
  22. Oliver Hader voted on patch set 4 CR 0 04/27/21, 20:56

  23. Oli Bartsch commented on patch set 4 CR 0 04/27/21, 20:58

    Reply

    Will wait for feedback first.
  24. Richard Haeser commented on patch set 4 05/14/21, 12:13

    I would suggest that we first implement this widget in EXT:widgets (https://github.com/FriendsOfTYPO3/widgets). We will first implement widgets there and will define which widgets will make it to core. EXT:widgets will be actively maintained again from now on. Would you like to create the pull request to that repository yourself? Or do you want me to do it? IMHO we should not merge this into core right now. I will not say this widget won't make it to core at all, but we are currently checking which kind of widgets should go into core.
  25. Benni Mack abandoned the change 11/08/21, 15:29

    abandoning patch... should go into EXT:widgets