Review main Merged

64939[FEATURE] Add new scheduler task and CLI command to clean up redirects

Frank Nägler CR +2 V +2 Hard +859 −5 updated 09/11/20, 06:50

Commit message

A new scheduler task and CLI command to clean up existing redirects
periodically under given conditions are added with this patch.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 4254

Show 2329 earlier messages
  1. Frank Nägler uploaded patch set 1 06/26/20, 14:31

  2. Frank Nägler uploaded patch set 2 06/26/20, 19:29

  3. Oliver Hader commented on patch set 2 06/29/20, 11:13

    CleanupRedirectsCommand.php:44 Unresolved

    superfluous comma & PHP error

    CleanupRedirectsTask.php:59 Unresolved

    superfluous comma & PHP error
  4. Frank Nägler uploaded patch set 3 07/03/20, 08:18

  5. Frank Nägler uploaded patch set 4 07/03/20, 08:25

  6. Andreas Kienast commented on patch set 4 CR -1 07/03/20, 08:32

    Feature-91712-RedirectModuleCleanupSchedulerTask.rst:12 Unresolved

    has been

    CleanupRedirectsCommand.php:45 Unresolved

    Commands support DI

    CleanupRedirectsCommand.php:90 Unresolved

    : int

    CleanupRedirectsAdditionalFieldProvider.php:31 Unresolved

    nope

    CleanupRedirectsAdditionalFieldProvider.php:63 Unresolved

    : array

    CleanupRedirectsAdditionalFieldProvider.php:83 Unresolved

    : array

    CleanupRedirectsAdditionalFieldProvider.php:92 Unresolved

    : void (if possible)

    CleanupRedirectsTask.php:26 Unresolved

    ?
  7. Andreas Kienast commented on patch set 4 07/03/20, 08:36

    CleanupRedirectsAdditionalFieldProvider.php:71 Unresolved

    PHP Warning: htmlspecialchars() expects parameter 1 to be string, array given in /var/www/html/typo3_src/typo3/sysext/core/Classes/Utility/GeneralUtility.php line 1189
  8. Frank Nägler uploaded patch set 5 07/03/20, 09:25

  9. Frank Nägler uploaded patch set 6 07/03/20, 09:30

  10. Frank Nägler uploaded patch set 7 07/03/20, 09:40

  11. Frank Nägler wrote 07/03/20, 09:58

    Unset private
  12. Andreas Kienast voted on patch set 7 V +1 CR +1 07/03/20, 10:06

  13. TYPO3com voted on patch set 5 V +1 07/03/20, 10:17 Completed build in 28m 41s on Fri, 3 Jul, 10:17 AM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4038

  14. TYPO3com voted on patch set 7 V +1 07/03/20, 10:35 Completed build in 47m 05s on Fri, 3 Jul, 10:35 AM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4040

  15. TYPO3com voted on patch set 6 V +1 07/03/20, 10:54 Completed build in 1h 06m 17s on Fri, 3 Jul, 10:54 AM Test Summary: 72868 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4039

  16. Benni Mack commented on patch set 7 CR -1 07/03/20, 11:36

    typo in the commit message.
  17. Benni Mack commented on patch set 7 07/03/20, 11:38

    in the first line...
  18. Benni Mack commented on patch set 7 07/03/20, 11:38

    "clenaup" should be called "cleanup"
  19. Benni Mack commented on patch set 7 07/03/20, 11:39

    I think it's important to correct such things, I sometimes look things up in the git commit message and this could be better
  20. Frank Nägler updated the commit message in patch set 8 07/03/20, 11:39

  21. Benni Mack commented on patch set 7 CR 0 07/03/20, 11:39

    It's not a must have, but a nice to have. I will remove my -1 (talked to you in person on this)
  22. Andreas Kienast voted on patch set 8 V +1 CR +1 07/03/20, 11:46

  23. TYPO3com voted on patch set 8 V +1 07/03/20, 12:22 Completed build in 28m 25s on Fri, 3 Jul, 12:22 PM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4044

  24. Oliver Hader commented on patch set 8 V +1 CR +1 07/03/20, 12:47

    Technically it's okay... I just want to raise that there are probably cases where redirect shall not be removed, in terms of "permanent redirect" which stays forever
  25. Frank Nägler commented on patch set 8 CR -1 07/03/20, 12:51

    on it
  26. Frank Nägler uploaded patch set 9 07/03/20, 19:10

  27. TYPO3com voted on patch set 9 V -1 07/03/20, 19:36 Completed build in 26m 42s on Fri, 3 Jul, 07:36 PM Test Summary: 72866 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4048

  28. TYPO3com voted on patch set 9 V +1 07/03/20, 19:49 Completed build in 1h 05m 48s on Fri, 3 Jul, 07:49 PM Test Summary: 72867 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4048

  29. Guido Schmechel commented on patch set 9 07/06/20, 09:32

    Feature-91712-RedirectModuleCleanupSchedulerTask.rst:1

    Should we add a hint to the new "protected" property here?
  1. Frank Nägler commented on patch set 9 CR -1 07/17/20, 12:26

    Feature-91712-RedirectModuleCleanupSchedulerTask.rst:1 Reply Unresolved

    good point, will push an update
  2. Frank Nägler uploaded patch set 10 07/17/20, 12:46

  3. TYPO3com voted on patch set 10 V +1 07/17/20, 12:59 Completed build in 12m 34s on Fri, 17 Jul, 12:58 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4132

  4. Daniel Goerz commented on patch set 10 CR -1 07/20/20, 18:55

    CleanupRedirectsCommand.php:94 Unresolved

    Annotations are superfluous

    CleanupRedirectsCommand.php:104

    So, whats with the path and statusCode options?

    RedirectService.php:135

    I think I'd rather see an object holding these values, e.g. a RedirectCleanupConfiguration, but that's maybe a matter of taste.

    RedirectService.php:147

    Why no $queryBuilder->createNamedParameter here?

    CleanupRedirectsTask.php:132

    Why are some properties nullable? The AdditionalFieldProvider casts everything. So that path is always a string and hitCount is always an int.
  5. Frank Nägler commented on patch set 10 07/24/20, 11:59

    CleanupRedirectsCommand.php:104 Reply Unresolved

    +1 good point, I missed this options.

    RedirectService.php:135 Reply Unresolved

    I am fully agree, will change it.

    RedirectService.php:147 Reply Unresolved

    left over from the very first patch, will refactor this part.

    CleanupRedirectsTask.php:132 Reply Unresolved

    will check it, but IIRC there was an issue with the type hinted and non nullable string/int values.
  6. Oliver Klee commented on patch set 10 07/24/20, 13:04

    Unresolved

    As this the verb, not the noun: cleanup -> clean up

    Unresolved

    cleanup -> clean up
  7. Frank Nägler uploaded patch set 11 07/24/20, 14:18

  8. TYPO3com voted on patch set 11 V -1 07/24/20, 14:30 Completed build in 11m 40s on Fri, 24 Jul, 02:30 PM Test Summary: 10 of 73438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4229

  9. Frank Nägler uploaded patch set 12 07/27/20, 06:28

  10. TYPO3com voted on patch set 12 V +1 07/27/20, 06:41 Completed build in 12m 41s on Mon, 27 Jul, 06:41 AM Test Summary: 72960 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4263

  11. Oliver Klee wrote 07/27/20, 06:51

    Removed reviewer Oliver Klee.
  12. Andreas Kienast uploaded patch set 13 07/31/20, 14:03

  13. Andreas Kienast voted on patch set 13 V +1 CR +1 07/31/20, 14:03

  14. TYPO3com voted on patch set 13 V +1 07/31/20, 14:15 Completed build in 11m 44s on Fri, 31 Jul, 02:15 PM Test Summary: 72954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4335

  15. Benni Mack commented on patch set 13 08/06/20, 10:55

    RedirectService.php:136 Unresolved

    looks good so far, but this method seems like it mixes concerns, as this class previously did not manage DB entries. So maybe we could move it to EXT:redirects/Classes/Repository/RedirectRepository.php where DB connections are already made?
  16. Frank Nägler uploaded patch set 14 08/07/20, 11:31

  17. TYPO3com voted on patch set 14 V +1 08/07/20, 11:42 Completed build in 11m 31s on Fri, 7 Aug, 11:42 AM Test Summary: 73013 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4469

  18. Andreas Kienast voted on patch set 14 V +1 CR +1 08/07/20, 11:44

  19. Jörg Bösche voted on patch set 14 V +1 CR +1 09/03/20, 13:04

  20. Daniel Goerz uploaded patch set 15 09/04/20, 11:39

  21. Daniel Goerz voted on patch set 15 V +1 CR +1 09/04/20, 11:42

  22. TYPO3com voted on patch set 15 V +1 09/04/20, 11:59 Completed build in 19m 03s on Fri, 4 Sep, 11:58 AM Test Summary: 73230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5233

  23. Jörg Bösche voted on patch set 15 V +1 CR +1 09/07/20, 07:52

  24. Andreas Kienast voted on patch set 15 V +2 CR +2 09/11/20, 06:49

  25. Andreas Kienast merged patch set 16 09/11/20, 06:50