64939[FEATURE] Add new scheduler task and CLI command to clean up redirects
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- Jörg Bösche +1
-
Verified V +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 18
- typo3/sysext/core/Documentation/Changelog/master/Feature-91712-RedirectModuleCleanupSchedulerTask.rst3new+46 −0
- typo3/sysext/redirects/Classes/Command/CleanupRedirectsCommand.php6new+105 −0
- typo3/sysext/redirects/Classes/Configuration/RedirectCleanupConfiguration.phpnew+101 −0
- typo3/sysext/redirects/Classes/Repository/RedirectRepository.php+42 −0
- typo3/sysext/redirects/Classes/Service/RedirectService.php5+14 −1
- typo3/sysext/redirects/Classes/Task/CleanupRedirectsAdditionalFieldProvider.php5new+106 −0
- typo3/sysext/redirects/Classes/Task/CleanupRedirectsTask.php4new+140 −0
- typo3/sysext/redirects/Configuration/TCA/sys_redirect.php+16 −1
- typo3/sysext/redirects/Configuration/Services.yaml+5 −0
- typo3/sysext/redirects/Resources/Private/Language/locallang.xlf+21 −0
- typo3/sysext/redirects/Resources/Private/Language/locallang_db.xlf+6 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectServiceTest_redirects.xmlnew+82 −0
- typo3/sysext/redirects/Tests/Functional/Service/IntegrityServiceTest.php+3 −1
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.phpnew+146 −0
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+9 −2
- typo3/sysext/redirects/composer.json+1 −0
- typo3/sysext/redirects/ext_localconf.php+15 −0
- typo3/sysext/redirects/ext_tables.sql+1 −0
Review log 4254
Show 2329 earlier messages
-
Frank Nägler uploaded patch set 1 06/26/20, 14:31
-
Frank Nägler uploaded patch set 2 06/26/20, 19:29
-
Oliver Hader commented on patch set 2 06/29/20, 11:13
CleanupRedirectsTask.php:59Unresolvedsuperfluous comma & PHP error -
Frank Nägler uploaded patch set 3 07/03/20, 08:18
-
Frank Nägler uploaded patch set 4 07/03/20, 08:25
-
Andreas Kienast commented on patch set 4 CR -1 07/03/20, 08:32
Feature-91712-RedirectModuleCleanupSchedulerTask.rst:12Unresolvedhas beenCleanupRedirectsCommand.php:45UnresolvedCommands support DICleanupRedirectsCommand.php:90Unresolved: intCleanupRedirectsAdditionalFieldProvider.php:31UnresolvednopeCleanupRedirectsAdditionalFieldProvider.php:63Unresolved: arrayCleanupRedirectsAdditionalFieldProvider.php:83Unresolved: arrayCleanupRedirectsAdditionalFieldProvider.php:92Unresolved: void (if possible)CleanupRedirectsTask.php:26Unresolved? -
Andreas Kienast commented on patch set 4 07/03/20, 08:36
CleanupRedirectsAdditionalFieldProvider.php:71UnresolvedPHP Warning: htmlspecialchars() expects parameter 1 to be string, array given in /var/www/html/typo3_src/typo3/sysext/core/Classes/Utility/GeneralUtility.php line 1189 -
Frank Nägler uploaded patch set 5 07/03/20, 09:25
-
Frank Nägler uploaded patch set 6 07/03/20, 09:30
-
Frank Nägler uploaded patch set 7 07/03/20, 09:40
-
Frank Nägler wrote 07/03/20, 09:58
Unset private -
Andreas Kienast voted on patch set 7 V +1 CR +1 07/03/20, 10:06
-
TYPO3com voted on patch set 5 V +1 07/03/20, 10:17 Completed build in 28m 41s on Fri, 3 Jul, 10:17 AM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4038
-
TYPO3com voted on patch set 7 V +1 07/03/20, 10:35 Completed build in 47m 05s on Fri, 3 Jul, 10:35 AM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4040
-
TYPO3com voted on patch set 6 V +1 07/03/20, 10:54 Completed build in 1h 06m 17s on Fri, 3 Jul, 10:54 AM Test Summary: 72868 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4039
-
Benni Mack commented on patch set 7 CR -1 07/03/20, 11:36
typo in the commit message. -
Benni Mack commented on patch set 7 07/03/20, 11:38
in the first line... -
Benni Mack commented on patch set 7 07/03/20, 11:38
"clenaup" should be called "cleanup" -
Benni Mack commented on patch set 7 07/03/20, 11:39
I think it's important to correct such things, I sometimes look things up in the git commit message and this could be better -
Frank Nägler updated the commit message in patch set 8 07/03/20, 11:39
-
Benni Mack commented on patch set 7 CR 0 07/03/20, 11:39
It's not a must have, but a nice to have. I will remove my -1 (talked to you in person on this) -
Andreas Kienast voted on patch set 8 V +1 CR +1 07/03/20, 11:46
-
TYPO3com voted on patch set 8 V +1 07/03/20, 12:22 Completed build in 28m 25s on Fri, 3 Jul, 12:22 PM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4044
-
Oliver Hader commented on patch set 8 V +1 CR +1 07/03/20, 12:47
Technically it's okay... I just want to raise that there are probably cases where redirect shall not be removed, in terms of "permanent redirect" which stays forever -
Frank Nägler commented on patch set 8 CR -1 07/03/20, 12:51
on it -
Frank Nägler uploaded patch set 9 07/03/20, 19:10
-
TYPO3com voted on patch set 9 V -1 07/03/20, 19:36 Completed build in 26m 42s on Fri, 3 Jul, 07:36 PM Test Summary: 72866 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4048
-
TYPO3com voted on patch set 9 V +1 07/03/20, 19:49 Completed build in 1h 05m 48s on Fri, 3 Jul, 07:49 PM Test Summary: 72867 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4048
-
Guido Schmechel commented on patch set 9 07/06/20, 09:32
Feature-91712-RedirectModuleCleanupSchedulerTask.rst:1Should we add a hint to the new "protected" property here?
-
Frank Nägler commented on patch set 9 CR -1 07/17/20, 12:26
Feature-91712-RedirectModuleCleanupSchedulerTask.rst:1Reply Unresolvedgood point, will push an update -
Frank Nägler uploaded patch set 10 07/17/20, 12:46
-
TYPO3com voted on patch set 10 V +1 07/17/20, 12:59 Completed build in 12m 34s on Fri, 17 Jul, 12:58 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4132
-
Daniel Goerz commented on patch set 10 CR -1 07/20/20, 18:55
CleanupRedirectsCommand.php:94UnresolvedAnnotations are superfluousCleanupRedirectsCommand.php:104So, whats with the path and statusCode options?RedirectService.php:135I think I'd rather see an object holding these values, e.g. a RedirectCleanupConfiguration, but that's maybe a matter of taste.RedirectService.php:147Why no $queryBuilder->createNamedParameter here?CleanupRedirectsTask.php:132Why are some properties nullable? The AdditionalFieldProvider casts everything. So that path is always a string and hitCount is always an int. -
Frank Nägler commented on patch set 10 07/24/20, 11:59
CleanupRedirectsCommand.php:104Reply Unresolved+1 good point, I missed this options.RedirectService.php:135Reply UnresolvedI am fully agree, will change it.RedirectService.php:147Reply Unresolvedleft over from the very first patch, will refactor this part.CleanupRedirectsTask.php:132Reply Unresolvedwill check it, but IIRC there was an issue with the type hinted and non nullable string/int values. -
Oliver Klee commented on patch set 10 07/24/20, 13:04
Unresolved
As this the verb, not the noun: cleanup -> clean upUnresolved
cleanup -> clean up -
Frank Nägler uploaded patch set 11 07/24/20, 14:18
-
TYPO3com voted on patch set 11 V -1 07/24/20, 14:30 Completed build in 11m 40s on Fri, 24 Jul, 02:30 PM Test Summary: 10 of 73438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4229
-
Frank Nägler uploaded patch set 12 07/27/20, 06:28
-
TYPO3com voted on patch set 12 V +1 07/27/20, 06:41 Completed build in 12m 41s on Mon, 27 Jul, 06:41 AM Test Summary: 72960 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4263
-
Oliver Klee wrote 07/27/20, 06:51
Removed reviewer Oliver Klee. -
Andreas Kienast uploaded patch set 13 07/31/20, 14:03
-
Andreas Kienast voted on patch set 13 V +1 CR +1 07/31/20, 14:03
-
TYPO3com voted on patch set 13 V +1 07/31/20, 14:15 Completed build in 11m 44s on Fri, 31 Jul, 02:15 PM Test Summary: 72954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4335
-
Benni Mack commented on patch set 13 08/06/20, 10:55
RedirectService.php:136Unresolvedlooks good so far, but this method seems like it mixes concerns, as this class previously did not manage DB entries. So maybe we could move it to EXT:redirects/Classes/Repository/RedirectRepository.php where DB connections are already made? -
Frank Nägler uploaded patch set 14 08/07/20, 11:31
-
TYPO3com voted on patch set 14 V +1 08/07/20, 11:42 Completed build in 11m 31s on Fri, 7 Aug, 11:42 AM Test Summary: 73013 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4469
-
Andreas Kienast voted on patch set 14 V +1 CR +1 08/07/20, 11:44
-
Jörg Bösche voted on patch set 14 V +1 CR +1 09/03/20, 13:04
-
Daniel Goerz uploaded patch set 15 09/04/20, 11:39
-
Daniel Goerz voted on patch set 15 V +1 CR +1 09/04/20, 11:42
-
TYPO3com voted on patch set 15 V +1 09/04/20, 11:59 Completed build in 19m 03s on Fri, 4 Sep, 11:58 AM Test Summary: 73230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5233
-
Jörg Bösche voted on patch set 15 V +1 CR +1 09/07/20, 07:52
-
Andreas Kienast voted on patch set 15 V +2 CR +2 09/11/20, 06:49
-
Andreas Kienast merged patch set 16 09/11/20, 06:50
CleanupRedirectsCommand.php:44Unresolved