Review 10.4 Merged

64947[BUGFIX] Convert SVG files if fileExtension is explicitly set

Oliver Hader CR +2 V +2 Easy +2 −2 updated 06/29/20, 19:00

Commit message

If a "fileExtension" is given in the Image Processing of FAL
(e.g. via Fluid ViewHelper setting "fileExtension='png'"),
then a SVG image is now converted to the target file extension
as well.

This might be important for various use cases when dealing
with SVGs

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Oliver Hader uploaded patch set 1 06/29/20, 18:10

  2. TYPO3com voted on patch set 1 V +1 06/29/20, 18:24 Completed build in 13m 37s on Mon, 29 Jun, 06:24 PM Test Summary: 73880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-58

  3. Daniel Goerz uploaded patch set 2 06/29/20, 18:32

  4. Oliver Hader commented on patch set 2 CR -1 06/29/20, 18:33

    wait before merging
  5. Oliver Hader uploaded patch set 3 06/29/20, 18:36

  6. Oliver Hader voted on patch set 3 CR -2 06/29/20, 18:43

  7. TYPO3com voted on patch set 3 V -1 06/29/20, 18:56 Completed build in 15m 56s on Mon, 29 Jun, 06:56 PM Test Summary: 1 of 74365 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-62

  8. TYPO3com voted on patch set 3 V +1 06/29/20, 18:59 Completed build in 34m 41s on Mon, 29 Jun, 06:59 PM Test Summary: 73878 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-62

  9. Oliver Hader voted on patch set 3 V +2 CR +2 06/29/20, 19:00

  10. Oliver Hader merged patch set 3 06/29/20, 19:00