64953[BUGFIX] Add missing composer.json adjustments for ext-libxml
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- Oliver Klee +1
-
Verified V +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 6
Review log 1213
-
Anja Leichsenring uploaded patch set 1 06/30/20, 15:08
-
TYPO3com voted on patch set 1 V +1 06/30/20, 15:21 Completed build in 13m 06s on Tue, 30 Jun, 03:21 PM Test Summary: 72866 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4024
-
Oliver Klee voted on patch set 1 CR +1 06/30/20, 15:53
-
Daniel Goerz voted on patch set 1 CR +1 06/30/20, 16:15
-
Oliver Hader commented on patch set 1 06/30/20, 21:24
-
Oliver Klee commented on patch set 1 06/30/20, 21:33
composer.json:24Reply UnresolvedIn the recycler extension, ext-libxml is only used in the tests, not in the production code. -
Stefan Froemken commented on patch set 1 CR -1 07/02/20, 05:52
composer.json:22UnresolvedNot needed as extensionmanager is not runable standalone without typo3/cms-core where libxml is already set as requirementcomposer.json:22UnresolvedNot needed, as frontend is not runable standalone without typo3/cms-core where libxml is already set as requirementcomposer.json:25UnresolvedNot needed, as recycler is not runable standalone without typo3/cms-core where libxml is already set as requirementcomposer.json:22UnresolvedNot needed, as t3editor is not runable standalone without typo3/cms-core where libxml is already set as requirement -
Anja Leichsenring commented on patch set 1 07/02/20, 05:55
> Patch Set 1: Code-Review-1 > > (4 comments) It is our convention to list all direct dependencies in each package we ship. This has been done here. -
Stefan Froemken commented on patch set 1 07/02/20, 06:01
> Patch Set 1: > > > Patch Set 1: Code-Review-1 > > > > (4 comments) > > It is our convention to list all direct dependencies in each package we ship. This has been done here. Yes, dependencies, not system requirements. That is part of typo3/cms-core where you also will find PHP 7.2 requirement -
Stefan Froemken voted on patch set 1 CR 0 07/02/20, 06:06
-
Daniel Goerz voted on patch set 1 V +1 07/20/20, 17:42
-
Andreas Kienast voted on patch set 1 V +2 CR +2 07/21/20, 06:41
-
Andreas Kienast merged patch set 2 07/21/20, 06:41
composer.json:24