Review 9.5 Merged

64973[BUGIFX] Store state of PageTitleProviderManager in cache

Daniel Goerz CR +2 V +2 Normal +81 −3 updated 06/30/20, 17:25

Commit message

To allow uncached plugins to provide a different page title,
page title providers must be also be called after uncached plugins
are rendered. To not loose the state of page title providers
that are called for cached entires, the state of page title
providers is stored in cache as well and provided for the
second title generation process after uncached objects are rendered.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 57

  1. Daniel Goerz commented on patch set 1 06/30/20, 16:46

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/PageTitle/PageTitleProviderManager.php
  2. TYPO3com voted on patch set 1 V -1 06/30/20, 16:49 Completed build in 39s on Tue, 30 Jun, 04:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-694

  3. Daniel Goerz uploaded patch set 2 06/30/20, 16:53

  4. Daniel Goerz commented on patch set 2 06/30/20, 16:54

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 06/30/20, 17:10 Completed build in 17m 22s on Tue, 30 Jun, 05:10 PM Test Summary: 75035 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-695

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 06/30/20, 17:25

  7. Daniel Goerz merged patch set 3 06/30/20, 17:25