Review main Merged

64993[BUGFIX] Increase size of sitemap_priority database field

Alexander Stehlik CR +2 V +2 Easy +10 −1 updated 07/20/20, 08:22

Commit message

The field size is increased to decimal(2,1) to be able to store
the value 1.0 zero in MariaDB databases.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Eric Chavaillaz +1
    • Christian Kuhn +1
    • Simon Ackermann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Eric Chavaillaz +1
    • Christian Kuhn +1
    • Simon Ackermann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1316

  1. Alexander Stehlik uploaded patch set 1 07/02/20, 11:53

  2. Alexander Stehlik updated the commit message in patch set 2 07/02/20, 11:57

  3. Alexander Stehlik wrote 07/02/20, 11:58

    Description "Edit commit message" removed
  4. TYPO3com voted on patch set 1 V -1 07/02/20, 12:12 Completed build in 17m 55s on Thu, 2 Jul, 12:11 PM Test Summary: 71557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4031

  5. TYPO3com voted on patch set 2 V +1 07/02/20, 12:18 Completed build in 19m 31s on Thu, 2 Jul, 12:18 PM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4032

  6. Eric Chavaillaz voted on patch set 2 V +1 CR +1 07/16/20, 07:50

  7. Simon Ackermann voted on patch set 2 V +1 CR +1 07/16/20, 08:54

  8. Christian Kuhn commented on patch set 2 07/16/20, 13:28

    +1 for master and v10. The feature has been introduced to v10 with https://review.typo3.org/c/Packages/TYPO3.CMS/+/59834 and does not exist in v9, so the Releases line should be changed to not contain 9.5
  9. Christian Kuhn uploaded patch set 3 07/16/20, 13:33

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 07/16/20, 13:38

  11. TYPO3com voted on patch set 3 V +1 07/16/20, 13:44 Completed build in 10m 57s on Thu, 16 Jul, 01:44 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4114

  12. Simon Ackermann voted on patch set 3 V +1 CR +1 07/16/20, 13:47

  13. Eric Chavaillaz voted on patch set 3 V +1 CR +1 07/16/20, 14:06

  14. Oliver Klee voted on patch set 3 CR +1 07/16/20, 15:17

  15. Benni Mack voted on patch set 3 V +2 CR +2 07/20/20, 08:22

  16. Benni Mack merged patch set 4 07/20/20, 08:22