Review main Merged

64994[FEATURE] Introduce wrapper for sessionStorage

Andreas Kienast CR +2 V +2 Hard +158 −94 updated 07/10/20, 09:53

Commit message

TYPO3 now ships a new module acting as wrapper for `sessionStorage`. It
behaves similar to `localStorage`, except that the stored data is dropped
after the browser session has ended.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1015

  1. Andreas Kienast uploaded patch set 1 07/03/20, 07:56

  2. Andreas Kienast uploaded patch set 2 07/03/20, 07:59

  3. TYPO3com voted on patch set 1 V -1 07/03/20, 08:22 Completed build in 25m 48s on Fri, 3 Jul, 08:22 AM Test Summary: 72867 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4034

  4. TYPO3com voted on patch set 2 V -1 07/03/20, 08:37 Completed build in 26m 10s on Fri, 3 Jul, 08:37 AM Test Summary: 1 of 73357 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4035

  5. TYPO3com voted on patch set 2 V +1 07/03/20, 09:03 Completed build in 1h 17m 54s on Fri, 3 Jul, 09:03 AM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4035

  6. Andreas Kienast uploaded patch set 3 07/03/20, 10:50

  7. Frank Nägler voted on patch set 3 V +1 CR +1 07/03/20, 12:22

  8. Oliver Hader commented on patch set 3 CR -1 07/03/20, 15:43

    on it
  9. Oliver Hader commented on patch set 3 07/03/20, 15:56

    AbstractClientStorage.ts:47 Unresolved

    this can be simplified
  10. Oliver Hader uploaded patch set 4 07/03/20, 16:10

  11. Oliver Hader voted on patch set 4 V +1 CR +1 07/03/20, 16:11

  12. TYPO3com voted on patch set 4 V -1 07/03/20, 16:43 Completed build in 33m 13s on Fri, 3 Jul, 04:43 PM Test Summary: 9 of 68423 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4047

  13. TYPO3com voted on patch set 4 V +1 07/06/20, 07:24 Completed build in 1h 00m 33s on Mon, 6 Jul, 07:24 AM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4049

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 07/10/20, 09:53

  15. Andreas Kienast wrote 07/10/20, 09:53

    Change has been successfully rebased and submitted as 9bba6b162a27a93d9875769ac4abed18847ebea2 by Andreas Fernandez