Review main Merged

64997[BUGFIX] Handle null values correctly to avoid PHP errors

Johannes Schlier CR +2 V +2 Easy +24 −1 updated 07/07/20, 09:11

Commit message

The new RteHtmlParser->transformTextForPersistence() method
expects a string value. Before this patch the given value
was simply passed without checking its type or casting it.

However, if "null" is handed in (by e.g. a translated record which
expects null), null is now kept.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 914

  1. Johannes Schlier uploaded patch set 1 07/06/20, 10:11

  2. TYPO3com voted on patch set 1 V +1 07/06/20, 10:40 Completed build in 28m 48s on Mon, 6 Jul, 10:40 AM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4050

  3. Oliver Klee commented on patch set 1 07/06/20, 14:56

    Can we cover this with tests?
  4. Benni Mack voted on patch set 1 V +1 CR +1 07/07/20, 06:47

  5. Daniel Gorges voted on patch set 1 V +1 CR +1 07/07/20, 06:48

  6. Benni Mack uploaded patch set 2 07/07/20, 07:23

  7. TYPO3com voted on patch set 2 V -1 07/07/20, 07:23 Completed build in 03s on Tue, 7 Jul, 07:23 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4051

  8. TYPO3com commented on patch set 2 07/07/20, 07:25 Completed build in 01m 25s on Tue, 7 Jul, 07:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4051

  9. Benni Mack uploaded patch set 3 07/07/20, 07:35

  10. TYPO3com voted on patch set 3 V -1 07/07/20, 07:35 Completed build in 01s on Tue, 7 Jul, 07:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4052

  11. TYPO3com voted on patch set 3 V +1 07/07/20, 08:58 Completed build in 54m 20s on Tue, 7 Jul, 08:58 AM Test Summary: 72872 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4052

  12. Oliver Hader voted on patch set 3 V +1 CR +1 07/07/20, 09:01

  13. Benni Mack commented on patch set 3 V +2 CR +2 07/07/20, 09:11

    > Patch Set 1: > > Can we cover this with tests? Done
  14. Benni Mack wrote 07/07/20, 09:11

    Change has been successfully rebased and submitted as 25871186d0aa045792c6db12de7bd171691bcd73 by Benni Mack