Review 10.4 Merged

64999[BUGFIX] Use URI of current request for referrer check

Oliver Hader CR +2 V +2 Easy +7 −9 updated 07/07/20, 08:55

Commit message

Instead of generating the URL to the backend login, the URI of the
current request is now used for the referrer check in backend login.
This fixes a redirect issue with password recovery links opened via
email.

The anchor-based reload detection has been replaced with a
localStorage-based solution as browsers don't trigger a new request if
the target location is already loaded, but only an achor is appended to
the URL.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 48

  1. Oliver Hader uploaded patch set 1 07/07/20, 07:34

  2. TYPO3com voted on patch set 1 V -1 07/07/20, 07:34 Completed build in 01s on Tue, 7 Jul, 07:34 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-70

  3. TYPO3com commented on patch set 1 07/07/20, 07:35 Completed build in 02s on Tue, 7 Jul, 07:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-70

  4. TYPO3com commented on patch set 1 07/07/20, 07:36 Completed build in 02s on Tue, 7 Jul, 07:36 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-70

  5. Oliver Hader voted on patch set 1 V +1 CR +1 07/07/20, 08:16

  6. TYPO3com voted on patch set 1 V +1 07/07/20, 08:36 Completed build in 33m 17s on Tue, 7 Jul, 08:36 AM Test Summary: 73883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-70

  7. Oliver Hader voted on patch set 1 V +2 CR +2 07/07/20, 08:55

  8. Oliver Hader merged patch set 1 07/07/20, 08:55