Review 10.4 Merged

65000[BUGFIX] Handle null values correctly to avoid PHP errors

Oliver Hader CR +2 V +2 Easy +24 −1 updated 07/07/20, 09:48

Commit message

The new RteHtmlParser->transformTextForPersistence() method
expects a string value. Before this patch the given value
was simply passed without checking its type or casting it.

However, if "null" is handed in (by e.g. a translated record which
expects null), null is now kept.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Oliver Hader uploaded patch set 1 07/07/20, 08:32

  2. Oliver Hader voted on patch set 1 V +1 CR +1 07/07/20, 09:02

  3. TYPO3com voted on patch set 1 V +1 07/07/20, 09:21 Completed build in 31m 02s on Tue, 7 Jul, 09:21 AM Test Summary: 73886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-71

  4. Oliver Hader voted on patch set 1 V +2 CR +2 07/07/20, 09:48

  5. Oliver Hader wrote 07/07/20, 09:48

    Change has been successfully rebased and submitted as e5d157de7fa0feba6a17ca15d6e7211cb03475f3 by Oliver Hader