Review 9.5 Merged

65003[BUGFIX] Use URI of current request for referrer check

Andreas Kienast CR +2 V +2 Easy +6 −9 updated 08/26/20, 11:20

Commit message

Instead of generating the URL to the backend login, the URI of the
current request is now used for the referrer check in backend login.
This fixes a redirect issue with password recovery links opened via
email.

The anchor-based reload detection has been replaced with a
localStorage-based solution as browsers don't trigger a new request if
the target location is already loaded, but only an achor is appended to
the URL.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jörg Bösche +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Andreas Kienast uploaded patch set 1 07/07/20, 11:11

  2. Andreas Kienast uploaded patch set 2 07/07/20, 11:12

  3. TYPO3com voted on patch set 1 V -1 07/07/20, 11:33 Completed build in 21m 20s on Tue, 7 Jul, 11:33 AM Test Summary: 75037 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-698

  4. TYPO3com voted on patch set 2 V -1 07/07/20, 11:34 Completed build in 22m 02s on Tue, 7 Jul, 11:34 AM Test Summary: 75037 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-699

  5. Andreas Kienast uploaded patch set 3 07/07/20, 12:08

  6. TYPO3com voted on patch set 3 V +1 07/07/20, 12:26 Completed build in 17m 36s on Tue, 7 Jul, 12:26 PM Test Summary: 75037 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-700

  7. Oliver Hader voted on patch set 3 CR +1 07/07/20, 12:28

  8. Jörg Bösche voted on patch set 3 CR +1 08/21/20, 08:27

  9. Andreas Kienast voted on patch set 3 V +2 CR +2 08/26/20, 11:20

  10. Andreas Kienast merged patch set 4 08/26/20, 11:20