65008[FEATURE] Introduce additional attributes for all page.include** TS configurations
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Page/PageRenderer.php9+84 −31
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst8new+91 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php3+94 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php3+66 −6
Review log 5375
Show 3450 earlier messages
-
Jan Stockfisch uploaded patch set 1 07/10/20, 14:43
-
Jan Stockfisch marked it work in progress 07/10/20, 14:44
-
TYPO3com voted on patch set 1 V +1 07/10/20, 14:58 Completed build in 14m 54s on Fri, 10 Jul, 02:58 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4060
-
Jan Stockfisch uploaded patch set 2 07/11/20, 11:22
-
Jan Stockfisch uploaded patch set 3 07/11/20, 11:25
-
Jan Stockfisch commented on patch set 3 07/11/20, 11:26
This change is ready for review. -
Jan Stockfisch updated the commit message in patch set 4 07/11/20, 11:29
-
TYPO3com voted on patch set 2 V -1 07/11/20, 11:39 Completed build in 16m 31s on Sat, 11 Jul, 11:39 AM Test Summary: 1 of 73350 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4067
-
TYPO3com voted on patch set 3 V +1 07/11/20, 11:48 Completed build in 17m 36s on Sat, 11 Jul, 11:48 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4068
-
TYPO3com voted on patch set 4 V +1 07/11/20, 11:53 Completed build in 23m 27s on Sat, 11 Jul, 11:53 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4069
-
Jan Stockfisch rebased onto patch set 5 07/21/20, 11:58
-
Jan Stockfisch wrote 07/21/20, 11:58
Description "Rebase" removed -
TYPO3com voted on patch set 5 V +1 07/21/20, 12:12 Completed build in 13m 43s on Tue, 21 Jul, 12:12 PM Test Summary: 72909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4179
-
Jan Stockfisch rebased onto patch set 6 08/08/20, 21:53
-
TYPO3com voted on patch set 6 V -1 08/08/20, 22:07 Completed build in 13m 54s on Sat, 8 Aug, 10:07 PM Test Summary: 71345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4509
-
TYPO3com voted on patch set 6 V +1 08/10/20, 07:04 Completed build in 12m 16s on Mon, 10 Aug, 07:04 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4532
-
Jörg Bösche voted on patch set 6 CR +1 09/01/20, 12:58
-
Benni Mack wrote 11/29/21, 10:04
Change destination moved from master to main -
Oliver Klee updated the commit message in patch set 7 11/29/21, 10:09
-
Benni Mack updated the commit message in patch set 8 11/29/21, 13:26
-
Claus Harup voted on patch set 8 V +1 CR +1 02/02/22, 11:04
-
Chris Müller commented on patch set 8 CR -1 02/02/22, 12:06
Please move the feature rst into the 12.0 folder (instead of master).Feature-91499-DataAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:25The "on" is superfluous. -
Oliver Klee commented on patch set 8 02/02/22, 13:45
PageRenderer.php:1056Please let's make this more specific. I guess (but I'm not completely sure) it should be this: @param array<string, string> $data -
Chris Müller uploaded patch set 9 02/02/22, 18:08
-
Chris Müller commented on patch set 9 02/02/22, 18:10
PageRenderer.php:1056ReplyDoneFeature-91499-DataAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:25ReplyDone -
core-ci voted on patch set 9 V -1 02/02/22, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22914
-
Chris Müller uploaded patch set 10 02/02/22, 18:14
-
core-ci voted on patch set 10 V +1 02/02/22, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22915
-
Oliver Klee wrote 02/04/22, 11:19
Removed cc Oliver Klee. -
Christian Kuhn commented on patch set 10 02/05/22, 08:09
ok. i guess we all agree this is codewise not a true beauty. but that's because of the general construct below, which we won't change with this patch. i agree however that we should have a way to add these data attributes since it's obviously needed in some scenarios. thus, imho: let's have a couple of tests that verify those strings are added to the output - pagerenderer has according tests that check rendered output for things already, so this should be possible to extend. when that's done, i'm fine and we should get it in. -
Chris Müller uploaded patch set 11 02/06/22, 17:15
-
core-ci voted on patch set 11 V +1 02/06/22, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23104
-
Chris Müller uploaded patch set 12 04/08/22, 08:28
-
core-ci voted on patch set 12 V -1 04/08/22, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25814
-
Chris Müller uploaded patch set 13 04/08/22, 08:47
-
core-ci voted on patch set 13 V +1 04/08/22, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25817
-
Chris Müller uploaded patch set 14 04/27/22, 16:43
-
core-ci voted on patch set 14 V -1 04/27/22, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26530
-
core-ci voted on patch set 14 V +1 04/27/22, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26530
-
Oliver Klee commented on patch set 14 04/27/22, 19:23
PageRenderer.php:2222We probably need to check that $properties[‘data’] is an array here (in addition to it being non-null) before passing it to renderDataAttributes in order to avoid a crash. We then could either silently ignore the problem or throw an exception with a helpful message. (I’d be fine either way.) Ditto for the other 3 places where renderDataAttributes is called. -
Stefan Bürk commented on patch set 14 04/27/22, 19:28
PageRenderer.php:2222ReplyCorrect me ... but should it not be doable by simply using it with is_array() ? If data is empty or not an array there is no need for any exception. ``` (is_array(($properties['data'] ?? false)) ? $this->renderDataAttributes($properties['data']) : '') ``` -
Oliver Klee commented on patch set 14 04/27/22, 19:40
PageRenderer.php:2222ReplyYes, that would be the "silently ignore the problem" way to do this (which I'd be fine with). -
Stefan Bürk commented on patch set 14 04/27/22, 19:43
PageRenderer.php:2222ReplyWould go here for the suppress way. Otherwise this should be fully checked on method start with early exception throwing. Both okay. -
Oliver Klee commented on patch set 14 04/27/22, 21:17
PageRenderer.php:2222ReplyAck -
Chris Müller uploaded patch set 15 04/30/22, 12:54
-
core-ci voted on patch set 15 V -1 04/30/22, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26691
-
core-ci voted on patch set 15 V +1 04/30/22, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26691
-
Oliver Klee wrote 05/05/22, 17:59
Removed cc Oliver Klee. -
Benni Mack uploaded patch set 16 10/05/22, 13:14
-
Benni Mack commented on patch set 16 10/05/22, 13:15
getting back to this... I recommend: * let's change the PageRenderer methods to accept $additionalAttributes and not just data attributes * Use GeneralUtility::implodeAttributes() instead of PageRenderer->renderDataAttributes
-
Benni Mack voted on patch set 16 CR -1 10/05/22, 13:15
-
core-ci voted on patch set 16 V -1 10/05/22, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32038
-
Benni Mack uploaded patch set 17 10/05/22, 15:20
-
Benni Mack uploaded patch set 18 10/05/22, 15:26
-
core-ci voted on patch set 17 V -1 10/05/22, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32044
-
core-ci voted on patch set 18 V -1 10/05/22, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32045
-
core-ci commented on patch set 18 10/05/22, 19:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32045
-
Oli Bartsch commented on patch set 18 10/05/22, 20:23
PageRenderer.php:2387This method seems to be unused.Feature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:25If I read the code right, this patch would allow to define any tag attribute, not only data- attributes.Feature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:65According to the `unset` calls, there are more reserved keywords -
Benni Mack uploaded patch set 19 10/06/22, 08:04
-
Benni Mack commented on patch set 19 10/06/22, 08:04
PageRenderer.php:2387ReplyDoneFeature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:25ReplyDoneFeature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:65ReplyDone -
core-ci voted on patch set 19 V +1 10/06/22, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32053
-
Benni Mack voted on patch set 19 CR +1 10/06/22, 11:17
-
Simon Schaufelberger commented on patch set 19 10/06/22, 12:29
Feature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:5one "=" too muchFeature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:39typeNum can be dropped as it is 0 by defaultPageRendererTest.php:400i would prefer using a dataprovider in this case, then you only need to assert once -
Georg Ringer uploaded patch set 20 10/06/22, 19:34
-
Georg Ringer commented on patch set 20 V +1 CR +1 10/06/22, 19:36
Feature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:5ReplyDoneFeature-91499-AdditionalAttributesForIncludeJSIncludeCSSAndAllOtherInclude.rst:39ReplyDonePageRendererTest.php:400ReplyI tested that but every call uses a different method and if the method name would be part of the dataprovider return value then you will find out that addJsFile and addJsFooterFile uses different arguments then the first 2. have been there and reverted it back because would needed 2 separate tests and that is not useful anymore -
core-ci voted on patch set 20 V +1 10/06/22, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32058
-
Benni Mack commented on patch set 20 CR +1 10/07/22, 08:12
PageRendererTest.php:400ReplyDone -
Simon Schaufelberger voted on patch set 20 V +1 CR +1 10/07/22, 08:41
-
Benni Mack voted on patch set 20 V +2 CR +2 10/07/22, 13:15
-
Benni Mack merged patch set 21 10/07/22, 13:15
-
Benjamin Kott commented on patch set 21 10/13/22, 07:23
post -1, single line includes are now broken example: includeCSSLibs.bootstrappackageicon = EXT:myext/Resources/Public/file.css -
Benni Mack commented on patch set 21 10/13/22, 09:51
Reply Unresolved
Yes. already on it https://review.typo3.org/c/Packages/TYPO3.CMS/+/76103 -
Oliver Hader commented on patch set 21 10/16/22, 09:39
Fails when using `if` TypoScript condition, see commentRequestHandler.php:448UnresolvedUnsetting `if.` is missing here, which would lead to an array to string conversion issue later. Instead of recycling the previous variable-space, probably it would have been better to use e.g. `includeCSS.attributes.data-value` instead of `includeCSS.data-value` - thus making it explicit with using `attributes` as a new variable-space. -
Oliver Hader commented on patch set 21 10/16/22, 09:46
RequestHandler.php:672UnresolvedSeems like it is used for arbitrary attributes in the resulting `<script>` tag. `data` seems to be the wrong naming here.RequestHandler.php:714UnresolvedSeems like it is used for arbitrary attributes in the resulting `<script>` tag. `data` seems to be the wrong naming here. -
Oliver Hader commented on patch set 21 10/16/22, 09:53
→ fix for the `if.` problem: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76123