65009[TASK] Remove jQuery from some FormEngine components
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Richard Haeser +1
- Stefan Froemken +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Richard Haeser +1
- Stefan Froemken +1
- TYPO3com +1 CI
Issues 1
Files 29
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Container/InlineControlContainer.ts2+7 −7
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/Extra/SelectBoxFilter.ts2+13 −20
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/InputDateTimeElement.ts+11 −6
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/InputLinkElement.ts+2 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectCheckBoxElement.ts+32 −30
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectMultipleSideBySideElement.ts+3 −3
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectSingleElement.ts+32 −23
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SlugElement.ts+60 −56
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/FieldWizard/LocalizationStateSelector.ts+31 −34
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/InlineRelation/AjaxDispatcher.ts+25 −11
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DateTimePicker.ts+5 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Utility.ts2+32 −0
- Build/types/TYPO3/index.d.ts2+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/Extra/SelectBoxFilter.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/InputDateTimeElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/InputLinkElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectCheckBoxElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectMultipleSideBySideElement.js+1 −1
Show 9 more files
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectSingleElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SlugElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/FieldWizard/LocalizationStateSelector.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/InlineRelation/AjaxDispatcher.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DateTimePicker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js3+15 −6
- typo3/sysext/backend/Resources/Public/JavaScript/Utility.js+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-91911-OptionElOfTypeJQueryInFormEnginesetSelectOptionFromExternalSource.rstnew+40 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+1 −1
Review log 2647
Show 1222 earlier messages
-
Andreas Kienast uploaded patch set 1 07/10/20, 14:47
-
TYPO3com voted on patch set 1 V +1 07/10/20, 15:07 Completed build in 18m 03s on Fri, 10 Jul, 03:07 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4061
-
Andreas Kienast uploaded patch set 2 07/16/20, 13:09
-
TYPO3com voted on patch set 2 V +1 07/16/20, 13:21 Completed build in 12m 13s on Thu, 16 Jul, 01:21 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4113
-
Andreas Kienast uploaded patch set 3 07/16/20, 14:27
-
Andreas Kienast uploaded patch set 4 07/16/20, 14:29
-
TYPO3com voted on patch set 3 V +1 07/16/20, 14:38 Completed build in 11m 35s on Thu, 16 Jul, 02:38 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4115
-
TYPO3com voted on patch set 4 V +1 07/16/20, 14:42 Completed build in 12m 36s on Thu, 16 Jul, 02:42 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4116
-
Andreas Kienast uploaded patch set 5 07/30/20, 14:48
-
TYPO3com voted on patch set 5 V +1 07/30/20, 14:59 Completed build in 10m 40s on Thu, 30 Jul, 02:59 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4314
-
Andreas Kienast uploaded patch set 6 07/31/20, 10:43
-
TYPO3com voted on patch set 6 V -1 07/31/20, 10:55 Completed build in 12m 43s on Fri, 31 Jul, 10:55 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4329
-
Andreas Kienast uploaded patch set 7 07/31/20, 11:34
-
TYPO3com voted on patch set 7 V +1 07/31/20, 11:45 Completed build in 11m 05s on Fri, 31 Jul, 11:45 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4331
-
Oliver Klee updated the commit message in patch set 8 07/31/20, 14:27
-
TYPO3com voted on patch set 8 V +1 07/31/20, 14:39 Completed build in 12m 02s on Fri, 31 Jul, 02:39 PM Test Summary: 72922 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4336
-
Andreas Kienast uploaded patch set 9 08/08/20, 19:49
-
TYPO3com voted on patch set 9 V +1 08/08/20, 20:02 Completed build in 12m 43s on Sat, 8 Aug, 08:02 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4507
-
Benjamin Franzke commented on patch set 9 08/20/20, 14:02
Utility.ts:125Add a return type declaration? mergeDeep mutates the parameter `target`, but also returns `target` – yes, that's what jQuery.extend does as well, but that feels a bit weird for a method called "merge". Because, calling the function with `target = mergeDeep(target, source)` is actually misleading, as `target` is automatically mutated, and calling mergeDeep(target, source) would be the same. The inspiration https://stackoverflow.com/a/48218209 provides an immutable implementation. Why did you choose to mutate target? Well, I guess because jQuery.extend does the same and I would probably be fine with mutating if we rather name this extendDeep.index.d.ts:61Unresolved$optionEl has been renamed to optionEL in FormEngine.jsindex.d.ts:61UnresolvedAs in FormEngine.js: Swap to "HTMLOptionElement | JQuery"?FormEngine.js:88UnresolvedHTMLOptionElementFormEngine.js:88UnresolvedNon deprecated type option in first place? HTMLOptionElement|$FormEngine.js:164UnresolvedAs we do not support IE11, we do not need Array.from workaround to iterator a NodeList: https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach#Browser_Compatibility Could be: optionEl.closest('select').querySelectorAll('[disabled]').forEach( -
Andreas Kienast commented on patch set 9 08/21/20, 12:46
Utility.ts:125Reply UnresolvedGood catch -
Andreas Kienast uploaded patch set 10 08/21/20, 12:51
-
TYPO3com voted on patch set 10 V -1 08/21/20, 13:08 Completed build in 15m 03s on Fri, 21 Aug, 01:08 PM Test Summary: 4 of 73154 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4803
-
TYPO3com voted on patch set 10 V +1 08/21/20, 13:15 Completed build in 37m 19s on Fri, 21 Aug, 01:15 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4803
-
Andreas Kienast uploaded patch set 11 08/21/20, 16:39
-
TYPO3com voted on patch set 11 V +1 08/21/20, 16:51 Completed build in 11m 54s on Fri, 21 Aug, 04:51 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4823
-
Benjamin Franzke commented on patch set 11 V -1 08/22/20, 18:12
SelectBoxFilter.ts:48This is needed for selectMultipleSideBySide with dropdown filter (select_multiplesidebyside_5 multiSelectFilterItems, enableMultiSelectFilterTextfield=true in EXT:styleguide). The filter does no longer work with this change. -
Andreas Kienast commented on patch set 11 08/24/20, 19:06
SelectBoxFilter.ts:48ReplyAck -
Andreas Kienast uploaded patch set 12 08/24/20, 19:10
-
TYPO3com voted on patch set 12 V +1 08/24/20, 19:21 Completed build in 11m 04s on Mon, 24 Aug, 07:21 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4921
-
Andreas Kienast uploaded patch set 13 08/26/20, 13:55
-
TYPO3com voted on patch set 13 V -1 08/26/20, 14:56 Completed build in 55m 21s on Wed, 26 Aug, 02:56 PM Test Summary: 9 of 72210 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4991
-
TYPO3com commented on patch set 13 08/27/20, 08:44 Completed build in 24m 12s on Thu, 27 Aug, 08:44 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4997
-
TYPO3com voted on patch set 13 V +1 08/27/20, 14:04 Completed build in 6h 07m 44s on Thu, 27 Aug, 02:04 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4997
-
Andreas Kienast uploaded patch set 14 09/04/20, 13:34
-
TYPO3com voted on patch set 14 V -1 09/04/20, 13:45 Completed build in 11m 22s on Fri, 4 Sep, 01:45 PM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5240
-
Andreas Kienast uploaded patch set 15 09/04/20, 13:52
-
Andreas Kienast uploaded patch set 16 09/04/20, 14:01
-
TYPO3com commented on patch set 15 09/04/20, 14:07 Completed build in 13m 47s on Fri, 4 Sep, 02:07 PM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5242
-
TYPO3com voted on patch set 16 V +1 09/04/20, 14:12 Completed build in 11m 24s on Fri, 4 Sep, 02:12 PM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5243
-
Andreas Kienast uploaded patch set 17 09/25/20, 09:30
-
TYPO3com voted on patch set 17 V +1 09/25/20, 09:44 Completed build in 14m 20s on Fri, 25 Sep, 09:44 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5931
-
Andreas Kienast uploaded patch set 18 09/26/20, 08:36
-
TYPO3com voted on patch set 18 V +1 09/26/20, 08:51 Completed build in 14m 34s on Sat, 26 Sep, 08:51 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5976
-
Stefan Froemken commented on patch set 18 V +1 CR +1 10/09/20, 21:27
Testing following elements: - Date Picker: open, close, switch month, choose date, changes mark record as modified - DateTime Picker: open, close, switch month, choose date, changes mark record as modified - SelectBoxFilter: options are found case insensitive. Filter works with UTF-8 values. Options with underscore and dash are found, too. Yeah, you can filter options by their debug value [2] ;-) - LinkWizard: Open, close. Opens LinkWizard with different views related to field - Toggle Checkboxes: Click on checkbox and label activates/deactivates checkbox. Toggle all works. Deactivate one checkbox deactivates toggle all checkbox. Perfect. - SelectSideBySide: edit, up, down, delete, top, bottom - SelectSingle: works. A change marks record as modified - Slug: edit, generate, marks record as modified - LocalizationState: Visible only for translations. Changing the radio button activates/deactivates field, except inline and group - Inline and Slug works so IMO AjaxDispatcher works Great work. Thank you.InlineControlContainer.ts:409UnresolvedRemoving default value here is OK for me as it will be set in next if-else -
Richard Haeser commented on patch set 18 V +1 CR +1 10/10/20, 10:01
Thanks Andreas. Everything seems to still work fine with all the fields. Also code seems fine to me. -
Anja Leichsenring voted on patch set 18 V +2 CR +2 10/10/20, 10:26
-
Anja Leichsenring merged patch set 19 10/10/20, 10:26
InlineControlContainer.ts:217Unresolved