Review main Merged

65009[TASK] Remove jQuery from some FormEngine components

Andreas Kienast CR +2 V +2 Hard +324 −215 updated 10/10/20, 10:26

Commit message

This patch removes jQuery from a major part of FormEngine components,
including elements, field wizards, enhancers and IRRE.

Additionally, the argument `optionEl` of the method
`FormEngine.setSelectOptionFromExternalSource()` accepts objects of type
`HTMLOptionElement` which renders jQuery objects obsolete, which has
been deprecated.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Richard Haeser +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Richard Haeser +1
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 1

Files 29

Show 9 more files

Review log 2647

Show 1222 earlier messages
  1. Andreas Kienast uploaded patch set 1 07/10/20, 14:47

  2. TYPO3com voted on patch set 1 V +1 07/10/20, 15:07 Completed build in 18m 03s on Fri, 10 Jul, 03:07 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4061

  3. Andreas Kienast uploaded patch set 2 07/16/20, 13:09

  4. TYPO3com voted on patch set 2 V +1 07/16/20, 13:21 Completed build in 12m 13s on Thu, 16 Jul, 01:21 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4113

  5. Andreas Kienast uploaded patch set 3 07/16/20, 14:27

  6. Andreas Kienast uploaded patch set 4 07/16/20, 14:29

  7. TYPO3com voted on patch set 3 V +1 07/16/20, 14:38 Completed build in 11m 35s on Thu, 16 Jul, 02:38 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4115

  8. TYPO3com voted on patch set 4 V +1 07/16/20, 14:42 Completed build in 12m 36s on Thu, 16 Jul, 02:42 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4116

  9. Andreas Kienast uploaded patch set 5 07/30/20, 14:48

  10. TYPO3com voted on patch set 5 V +1 07/30/20, 14:59 Completed build in 10m 40s on Thu, 30 Jul, 02:59 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4314

  11. Andreas Kienast uploaded patch set 6 07/31/20, 10:43

  12. TYPO3com voted on patch set 6 V -1 07/31/20, 10:55 Completed build in 12m 43s on Fri, 31 Jul, 10:55 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4329

  13. Andreas Kienast uploaded patch set 7 07/31/20, 11:34

  14. TYPO3com voted on patch set 7 V +1 07/31/20, 11:45 Completed build in 11m 05s on Fri, 31 Jul, 11:45 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4331

  15. Oliver Klee updated the commit message in patch set 8 07/31/20, 14:27

  16. TYPO3com voted on patch set 8 V +1 07/31/20, 14:39 Completed build in 12m 02s on Fri, 31 Jul, 02:39 PM Test Summary: 72922 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4336

  17. Andreas Kienast uploaded patch set 9 08/08/20, 19:49

  18. TYPO3com voted on patch set 9 V +1 08/08/20, 20:02 Completed build in 12m 43s on Sat, 8 Aug, 08:02 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4507

  19. Benjamin Franzke commented on patch set 9 08/20/20, 14:02

    InlineControlContainer.ts:217 Unresolved

    How about "DocumentService.ready().then((document: Document): void => {" to avoid usage of the global document variable?

    Utility.ts:125

    Add a return type declaration? mergeDeep mutates the parameter `target`, but also returns `target` – yes, that's what jQuery.extend does as well, but that feels a bit weird for a method called "merge". Because, calling the function with `target = mergeDeep(target, source)` is actually misleading, as `target` is automatically mutated, and calling mergeDeep(target, source) would be the same. The inspiration https://stackoverflow.com/a/48218209 provides an immutable implementation. Why did you choose to mutate target? Well, I guess because jQuery.extend does the same and I would probably be fine with mutating if we rather name this extendDeep.

    index.d.ts:61 Unresolved

    $optionEl has been renamed to optionEL in FormEngine.js

    index.d.ts:61 Unresolved

    As in FormEngine.js: Swap to "HTMLOptionElement | JQuery"?

    FormEngine.js:88 Unresolved

    HTMLOptionElement

    FormEngine.js:88 Unresolved

    Non deprecated type option in first place? HTMLOptionElement|$

    FormEngine.js:164 Unresolved

    As we do not support IE11, we do not need Array.from workaround to iterator a NodeList: https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach#Browser_Compatibility Could be: optionEl.closest('select').querySelectorAll('[disabled]').forEach(
  20. Andreas Kienast commented on patch set 9 08/21/20, 12:46

    Utility.ts:125 Reply Unresolved

    Good catch
  21. Andreas Kienast uploaded patch set 10 08/21/20, 12:51

  22. TYPO3com voted on patch set 10 V -1 08/21/20, 13:08 Completed build in 15m 03s on Fri, 21 Aug, 01:08 PM Test Summary: 4 of 73154 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4803

  1. TYPO3com voted on patch set 10 V +1 08/21/20, 13:15 Completed build in 37m 19s on Fri, 21 Aug, 01:15 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4803

  2. Andreas Kienast uploaded patch set 11 08/21/20, 16:39

  3. TYPO3com voted on patch set 11 V +1 08/21/20, 16:51 Completed build in 11m 54s on Fri, 21 Aug, 04:51 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4823

  4. Benjamin Franzke commented on patch set 11 V -1 08/22/20, 18:12

    SelectBoxFilter.ts:48

    This is needed for selectMultipleSideBySide with dropdown filter (select_multiplesidebyside_5 multiSelectFilterItems, enableMultiSelectFilterTextfield=true in EXT:styleguide). The filter does no longer work with this change.
  5. Andreas Kienast commented on patch set 11 08/24/20, 19:06

    SelectBoxFilter.ts:48 Reply

    Ack
  6. Andreas Kienast uploaded patch set 12 08/24/20, 19:10

  7. TYPO3com voted on patch set 12 V +1 08/24/20, 19:21 Completed build in 11m 04s on Mon, 24 Aug, 07:21 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4921

  8. Andreas Kienast uploaded patch set 13 08/26/20, 13:55

  9. TYPO3com voted on patch set 13 V -1 08/26/20, 14:56 Completed build in 55m 21s on Wed, 26 Aug, 02:56 PM Test Summary: 9 of 72210 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4991

  10. TYPO3com commented on patch set 13 08/27/20, 08:44 Completed build in 24m 12s on Thu, 27 Aug, 08:44 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4997

  11. TYPO3com voted on patch set 13 V +1 08/27/20, 14:04 Completed build in 6h 07m 44s on Thu, 27 Aug, 02:04 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4997

  12. Andreas Kienast uploaded patch set 14 09/04/20, 13:34

  13. TYPO3com voted on patch set 14 V -1 09/04/20, 13:45 Completed build in 11m 22s on Fri, 4 Sep, 01:45 PM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5240

  14. Andreas Kienast uploaded patch set 15 09/04/20, 13:52

  15. Andreas Kienast uploaded patch set 16 09/04/20, 14:01

  16. TYPO3com commented on patch set 15 09/04/20, 14:07 Completed build in 13m 47s on Fri, 4 Sep, 02:07 PM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5242

  17. TYPO3com voted on patch set 16 V +1 09/04/20, 14:12 Completed build in 11m 24s on Fri, 4 Sep, 02:12 PM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5243

  18. Andreas Kienast uploaded patch set 17 09/25/20, 09:30

  19. TYPO3com voted on patch set 17 V +1 09/25/20, 09:44 Completed build in 14m 20s on Fri, 25 Sep, 09:44 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5931

  20. Andreas Kienast uploaded patch set 18 09/26/20, 08:36

  21. TYPO3com voted on patch set 18 V +1 09/26/20, 08:51 Completed build in 14m 34s on Sat, 26 Sep, 08:51 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5976

  22. Stefan Froemken commented on patch set 18 V +1 CR +1 10/09/20, 21:27

    Testing following elements: - Date Picker: open, close, switch month, choose date, changes mark record as modified - DateTime Picker: open, close, switch month, choose date, changes mark record as modified - SelectBoxFilter: options are found case insensitive. Filter works with UTF-8 values. Options with underscore and dash are found, too. Yeah, you can filter options by their debug value [2] ;-) - LinkWizard: Open, close. Opens LinkWizard with different views related to field - Toggle Checkboxes: Click on checkbox and label activates/deactivates checkbox. Toggle all works. Deactivate one checkbox deactivates toggle all checkbox. Perfect. - SelectSideBySide: edit, up, down, delete, top, bottom - SelectSingle: works. A change marks record as modified - Slug: edit, generate, marks record as modified - LocalizationState: Visible only for translations. Changing the radio button activates/deactivates field, except inline and group - Inline and Slug works so IMO AjaxDispatcher works Great work. Thank you.

    InlineControlContainer.ts:409 Unresolved

    Removing default value here is OK for me as it will be set in next if-else
  23. Richard Haeser commented on patch set 18 V +1 CR +1 10/10/20, 10:01

    Thanks Andreas. Everything seems to still work fine with all the fields. Also code seems fine to me.
  24. Anja Leichsenring voted on patch set 18 V +2 CR +2 10/10/20, 10:26

  25. Anja Leichsenring merged patch set 19 10/10/20, 10:26