Review main Merged Breaking

65011[!!!][TASK] Remove lockToDomain feature for BE and FE

Benni Mack CR +2 V +2 Hard +66 −353 updated 07/21/20, 11:18

Commit message

Both fe_users/be_users and be_groups/fe_groups have a feature called "lockToDomain".

Although it is called the same, it has a different use-case:

* Users: If lockToDomain is set, the user is only allowed to login when a given HTTP_HOST is given.
* Groups: If lockToDomain is set, the group is only added to the logged in user, if the HTTP_HOST matches this domain.

Both features are rarely used, and even in multi-tenant setups not viable or flexible
enough. In addition, the features are not any additional security measures as HTTP_HOST can be faked.

They both add unneeded complexity for the rare use of a similar feature,
a custom extension should be used.

Plus: All of these features can be added via extensions, depending on a
specific use case of an installation, so _if_ people use it, custom extensions
should be used instead for the specific use case they have.

The database fields, TCA definitions, labels, domain model logic in Extbase
and actual validation within the AuthenticationService and BE_USER are removed
without any substitution.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 28

Show 8 more files

Review log 710

  1. Benni Mack uploaded patch set 1 07/10/20, 18:31

  2. TYPO3com voted on patch set 1 V -1 07/10/20, 18:45 Completed build in 14m 14s on Fri, 10 Jul, 06:45 PM Test Summary: 6 of 73314 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4064

  3. Benni Mack uploaded patch set 2 07/13/20, 11:03

  4. TYPO3com voted on patch set 2 V +1 07/13/20, 11:26 Completed build in 18m 00s on Mon, 13 Jul, 11:26 AM Test Summary: 72821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4079

  5. Georg Ringer voted on patch set 2 V +1 CR +1 07/13/20, 17:19

  6. Daniel Goerz uploaded patch set 3 07/20/20, 17:50

  7. Daniel Goerz voted on patch set 3 V +1 CR +1 07/20/20, 17:51

  8. TYPO3com voted on patch set 3 V +1 07/20/20, 18:02 Completed build in 11m 40s on Mon, 20 Jul, 06:02 PM Test Summary: 72903 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4163

  9. Georg Ringer voted on patch set 3 V +2 CR +2 07/21/20, 11:18

  10. Georg Ringer merged patch set 4 07/21/20, 11:18