Review 10.4 Merged

65025[BUGFIX] Implement Tag interface for DocBlock tags

Benni Mack CR +2 V +2 Easy +19 −2 updated 07/21/20, 12:46

Commit message

Since phpdocumentor/reflection-docbloc 5.2.x a tag is required to
implement also the phpDocumentor\Reflection\DocBlock\Tags\Formatter\Tag
interface.

This patch implements the tag interface for the Null_ tag defined in
Extbase.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Benni Mack commented on patch set 1 07/21/20, 11:35

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 07/21/20, 11:51 Completed build in 16m 17s on Tue, 21 Jul, 11:51 AM Test Summary: 73876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-100

  3. TYPO3com voted on patch set 1 V +1 07/21/20, 12:03 Completed build in 44m 58s on Tue, 21 Jul, 12:03 PM Test Summary: 73890 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-100

  4. Simon Gilli voted on patch set 1 V +1 CR +1 07/21/20, 12:45

  5. Benni Mack voted on patch set 1 V +2 CR +2 07/21/20, 12:46

  6. Benni Mack merged patch set 2 07/21/20, 12:46