Review 9.5 Merged

65027[BUGFIX] Limit amount of data fetched by the page tree

Richard Haeser CR +2 V +2 Hard +711 −136 updated 08/07/20, 12:36

Commit message

Page tree will fetch just 2 levels of pages plus pages which
are expanded on the initial load.
Next levels are fetched on demand via Ajax when expanding the node.
Search work server side now (hit enter). To clear search, click on "x"
button.
If you select a page when filtering, it's kept selected after
removing the filter.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • Benjamin Schi +1
    • Sybille Peters +1
    • Dennis Prinse +1
    • TYPO3com +1 CI

Issues 3

Files 8

Review log 1517

  1. Richard Haeser commented on patch set 1 07/23/20, 08:18

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/Page/TreeController.php * typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php * typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeToolbar.js
  2. TYPO3com voted on patch set 1 V -1 07/23/20, 08:19 Completed build in 48s on Thu, 23 Jul, 08:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-710

  3. Richard Haeser abandoned the change 07/23/20, 11:30

  4. Richard Haeser restored the change 07/23/20, 11:34

  5. Richard Haeser uploaded patch set 2 07/23/20, 11:34

  6. Richard Haeser commented on patch set 2 07/23/20, 11:34

    This change is ready for review.
  7. TYPO3com voted on patch set 2 V +1 07/23/20, 11:47 Completed build in 13m 14s on Thu, 23 Jul, 11:47 AM Test Summary: 75049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-711

  8. Sybille Peters voted on patch set 2 V +1 07/23/20, 12:11

  9. Dennis Prinse voted on patch set 2 V +1 07/23/20, 12:23

  10. Benjamin Schi voted on patch set 2 V +1 07/23/20, 13:42

  11. Richard Haeser voted on patch set 2 V +2 CR +2 07/23/20, 13:44

  12. Richard Haeser merged patch set 3 07/23/20, 13:44

  13. Andreas Kienast commented on patch set 3 07/28/20, 11:33

    PageTree.js:342 Unresolved

    This method is undefined in v9
  14. Oliver Hader commented on patch set 3 07/29/20, 09:10

    PageTree.js:334

    what about `_this.nodes.splice(index, 0, ...nodes)` instead - no need for `forEach`

    PageTree.js:338 Unresolved

    the following `_this.*` calls should have a comment on what's actually going on here
  15. Oliver Hader commented on patch set 3 07/29/20, 09:15

    PageTree.js:334 Reply Unresolved

    Okay... forgot about non-ES6 scenarios in TYPO3 v9
  16. Benni Mack wrote 08/07/20, 11:46

    Created a revert of this change as Iaf0297b8a47883f44d697f988147ffcfdd3636c3
  17. Benni Mack wrote 08/07/20, 12:36

    Created a revert of this change as Ic9a4e543daab4697605073a00e7a51ab139a67a8