Review main Merged

65036[TASK] Move EXT:about into EXT:backend

Benni Mack CR +2 V +2 Hard +116 −516 updated 07/30/20, 13:14

Commit message

The about system extension is responsible for the log-in screen (if EXT:dashboard
is not installed), and despite having just one single controller, EXT:backend
is depending on the extension / module when EXT:dashboard is not installed.

To help newcomers reduce the number of (from their PoV) extensions
that need to be installed via composer, or need to be upgraded, this package
is moved into EXT:backend.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 33

Show 13 more files

Review log 911

  1. Benni Mack uploaded patch set 1 07/13/20, 19:53

  2. TYPO3com voted on patch set 1 V +1 07/13/20, 20:10 Completed build in 16m 26s on Mon, 13 Jul, 08:10 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4089

  3. Richard Haeser commented on patch set 1 07/14/20, 21:32

    FYI: I just see this and I remembered we use the language file of EXT:about in EXT:dashboard (the T3GeneralInformationWidget). I will create a patch to have that in it's own language file.
  4. Richard Haeser commented on patch set 1 07/14/20, 21:33

    > Patch Set 1: > > FYI: I just see this and I remembered we use the language file of EXT:about in EXT:dashboard (the T3GeneralInformationWidget). I will create a patch to have that in it's own language file. AH you already have that in https://review.typo3.org/c/Packages/TYPO3.CMS/+/64504
  5. Richard Haeser commented on patch set 1 07/14/20, 21:37

    > Patch Set 1: > > > Patch Set 1: > > > > FYI: I just see this and I remembered we use the language file of EXT:about in EXT:dashboard (the T3GeneralInformationWidget). I will create a patch to have that in it's own language file. > > AH you already have that in https://review.typo3.org/c/Packages/TYPO3.CMS/+/64504 Well, that is actually the wrong way indeed. Will fix it
  6. Andreas Kienast commented on patch set 1 07/15/20, 14:18

    composer.json:89 Unresolved

    Shouldn't this be in EXT:backend/composer.json?
  7. Benni Mack uploaded patch set 2 07/29/20, 09:23

  8. TYPO3com voted on patch set 2 V +1 07/29/20, 09:36 Completed build in 12m 52s on Wed, 29 Jul, 09:36 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4298

  9. Georg Ringer voted on patch set 2 V +1 CR +1 07/30/20, 12:27

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 07/30/20, 13:14

  11. Andreas Kienast merged patch set 3 07/30/20, 13:14