65037[BUGFIX] additionalWhere and excludedDoktypes in XML Site Map Builder
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 68
-
Mohsin Khan uploaded patch set 1 07/14/20, 12:03
-
Mohsin Khan updated the commit message in patch set 2 07/14/20, 12:04
-
TYPO3com voted on patch set 1 V -1 07/14/20, 12:18 Completed build in 15m 10s on Tue, 14 Jul, 12:18 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4091
-
TYPO3com voted on patch set 2 V +1 07/14/20, 12:24 Completed build in 19m 16s on Tue, 14 Jul, 12:24 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4092
-
Richard Haeser commented on patch set 2 CR -2 07/14/20, 21:28
I'm in doubt if this is something you want to have by default. For you it might be "logical" to exclude subpages as well, but in my cases this is not the wanted behaviour. Will give this another thought. Maybe I change my mind or maybe we can come up with a solution that works in both cases. For now I will add a -2 to block getting this merged as in the current state it will also not include pages that are subpages of a no_index page. For sure, that is something you don't want. -
Mohsin Khan commented on patch set 2 07/15/20, 10:42
> Patch Set 2: Code-Review-2 > > I'm in doubt if this is something you want to have by default. For you it might be "logical" to exclude subpages as well, but in my cases this is not the wanted behaviour. Will give this another thought. Maybe I change my mind or maybe we can come up with a solution that works in both cases. > > For now I will add a -2 to block getting this merged as in the current state it will also not include pages that are subpages of a no_index page. For sure, that is something you don't want. in my case, there were some pages for testing which I made disable and they have some child as well but the sitemap was listing all its child pages with some testing content on it. and only excluding that parent which was weird for me. -
Richard Haeser commented on patch set 2 04/28/21, 07:04
We will not implement this as it will not help most of the people. If you want, you can always create your own Sitemap Dataprovider that will implement this. I will abandon this patch for now. If you think this should definitely be in, please contact me at #typo3-cms-coredev channel on Slack. -
Richard Haeser abandoned the change 04/28/21, 07:04