Review main Merged

65038[BUGFIX] Move translations of general information widget to EXT:dashboard

Richard Haeser CR +2 V +2 Easy +9 −2 updated 07/15/20, 14:41

Commit message

Removed the dependency on EXT:about by adding translations for the
General Information widget to EXT:dashboard itself.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jigal van Hemert +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Richard Haeser uploaded patch set 1 07/14/20, 21:45

  2. TYPO3com voted on patch set 1 V +1 07/14/20, 22:01 Completed build in 15m 54s on Tue, 14 Jul, 10:01 PM Test Summary: 72861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4097

  3. Koen Wouters voted on patch set 1 V +1 CR +1 07/15/20, 06:49

  4. Benni Mack commented on patch set 1 07/15/20, 07:30

    locallang.xlf:138

    we should add the noopener noreferrer here as well (to the license link), also, you could probably use CDATA to make this string more readable ;)
  5. Richard Haeser commented on patch set 1 07/15/20, 11:33

    locallang.xlf:138 Reply Unresolved

    What was I thinking... A simple copy / paste that would do the job... Will change it indeed ;-)
  6. Richard Haeser uploaded patch set 2 07/15/20, 12:09

  7. TYPO3com voted on patch set 2 V +1 07/15/20, 12:20 Completed build in 11m 01s on Wed, 15 Jul, 12:20 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4101

  8. Jigal van Hemert voted on patch set 2 V +1 CR +1 07/15/20, 14:38

  9. Benni Mack voted on patch set 2 V +2 CR +2 07/15/20, 14:41

  10. Benni Mack merged patch set 3 07/15/20, 14:41