Review main Merged

65039[TASK] Remove inline JavaScript from backend paginate view helper

Oliver Hader CR +2 V +2 Normal +46 −26 updated 07/17/20, 12:25

Commit message

Inline JavaScript used in the backend paginate widget is replaced by
data-attribute instructions handled by `GlobalEventHandler` module.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1013

  1. Oliver Hader uploaded patch set 1 07/15/20, 15:16

  2. Oliver Hader commented on patch set 1 07/15/20, 15:20

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 07/15/20, 15:29 Completed build in 12m 34s on Wed, 15 Jul, 03:29 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4102

  4. Oliver Hader uploaded patch set 2 07/15/20, 15:34

  5. TYPO3com voted on patch set 2 V +1 07/15/20, 15:46 Completed build in 11m 46s on Wed, 15 Jul, 03:46 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4103

  6. Oliver Hader voted on patch set 2 CR -1 07/15/20, 21:47

  7. Oliver Hader commented on patch set 2 07/15/20, 21:47

    splitting into patches
  8. Oliver Hader uploaded patch set 3 07/15/20, 21:50

  9. TYPO3com voted on patch set 3 V +1 07/15/20, 22:01 Completed build in 11m 19s on Wed, 15 Jul, 10:01 PM Test Summary: 72941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4105

  10. Benni Mack voted on patch set 3 V +1 CR +1 07/16/20, 13:36

  11. Oliver Hader wrote 07/17/20, 12:02

    Topic set to inline-javascript
  12. Oliver Hader voted on patch set 3 V +2 CR +2 07/17/20, 12:25

  13. Oliver Hader merged patch set 4 07/17/20, 12:25