65039[TASK] Remove inline JavaScript from backend paginate view helper
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/GlobalEventHandler.ts+33 −0
- typo3/sysext/backend/Resources/Public/JavaScript/GlobalEventHandler.js+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Widget/Controller/PaginateController.php+5 −5
- typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Be/Widget/Paginate/Index.html+7 −20
Review log 1013
-
Oliver Hader uploaded patch set 1 07/15/20, 15:16
-
Oliver Hader commented on patch set 1 07/15/20, 15:20
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 07/15/20, 15:29 Completed build in 12m 34s on Wed, 15 Jul, 03:29 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4102
-
Oliver Hader uploaded patch set 2 07/15/20, 15:34
-
TYPO3com voted on patch set 2 V +1 07/15/20, 15:46 Completed build in 11m 46s on Wed, 15 Jul, 03:46 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4103
-
Oliver Hader voted on patch set 2 CR -1 07/15/20, 21:47
-
Oliver Hader commented on patch set 2 07/15/20, 21:47
splitting into patches -
Oliver Hader uploaded patch set 3 07/15/20, 21:50
-
TYPO3com voted on patch set 3 V +1 07/15/20, 22:01 Completed build in 11m 19s on Wed, 15 Jul, 10:01 PM Test Summary: 72941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4105
-
Benni Mack voted on patch set 3 V +1 CR +1 07/16/20, 13:36
-
Oliver Hader wrote 07/17/20, 12:02
Topic set to inline-javascript -
Oliver Hader voted on patch set 3 V +2 CR +2 07/17/20, 12:25
-
Oliver Hader merged patch set 4 07/17/20, 12:25