Review 9.5 Merged

65041[BUGFIX] Adjust processing order of routes during URL generation

Oliver Hader CR +2 V +2 Hard +541 −13 updated 07/25/20, 09:27

Commit message

Prior to this patch routes were processed in reverse definition order.
Routes defined last came first. Depending on the existence of variable
defaults this behavior produced a couple of unexpected results.

  first:
    routePath: '/route/{a}/{b}'
  second:
    routePath: '/route/{c}'
    defaults:
      c: '0'

The example above, processed in reverse order and having parameters
`a` and `b` given, still resulted in `second` route being used since
the missing parameter `c` was defined by corresponding variable default.

This change adjusts the order of routes depending on given parameters,
completeness of a route (when all parameters are given, even defaults).
Sorting is adjusted based on the following criteria:

* default routes (e.g. `/my-page`) - processed later
* static routes (e.g. `/my-page/list`) - processed later
* all variables are given (complete) - processed earlier
  (e.g. parameters `a` and `b` are given for route `/route/{a}/{b}`)
* all mandatory variables are given (complete) - processed earlier
* less missing variable defaults - processed earlier
* less variable defaults amount - processed earlier

Tests in class `RouteSorterTest` provide more examples & details.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 46

  1. Oliver Hader uploaded patch set 1 07/15/20, 21:16

  2. TYPO3com voted on patch set 1 V -1 07/15/20, 21:17 Completed build in 26s on Wed, 15 Jul, 09:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-705

  3. Oliver Hader uploaded patch set 2 07/15/20, 21:54

  4. TYPO3com voted on patch set 2 V +1 07/15/20, 22:06 Completed build in 11m 40s on Wed, 15 Jul, 10:06 PM Test Summary: 75115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-706

  5. Oliver Hader voted on patch set 2 V +2 CR +2 07/25/20, 09:27

  6. Oliver Hader merged patch set 3 07/25/20, 09:27