Review main Abandoned

65045[BUGFIX] Do not make PropertyMapper a singleton

Benni Mack CR 0 V 0 Easy +26 −22 updated 07/25/20, 21:33

Commit message

In order to re-use the property mapper functionality in multiple
plugins of Extbase, the property mapper is not a singleton anymore.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 810

  1. Benni Mack uploaded patch set 1 07/16/20, 15:58

  2. TYPO3com voted on patch set 1 V -1 07/16/20, 16:10 Completed build in 11m 53s on Thu, 16 Jul, 04:10 PM Test Summary: 204 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4119

  3. Benni Mack uploaded patch set 2 07/20/20, 04:05

  4. TYPO3com voted on patch set 2 V +1 07/20/20, 04:17 Completed build in 11m 33s on Mon, 20 Jul, 04:17 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4154

  5. Daniel Goerz voted on patch set 2 CR +1 07/20/20, 07:40

  6. Daniel Goerz voted on patch set 2 V +1 07/20/20, 18:33

  7. Daniel Goerz commented on patch set 2 V 0 07/21/20, 07:02

    did not test behavior in case of errors yet
  8. Benni Mack commented on patch set 2 CR -2 07/21/20, 10:01

    will go with a different approach
  9. Daniel Goerz voted on patch set 2 CR 0 07/21/20, 10:03

  10. Benni Mack abandoned the change 07/25/20, 21:33

    Actually, I think we don't need this anymore