Review main Merged

65046[TASK] Add possibility to create random values in JavaScript

Oliver Hader CR +2 V +2 Normal +65 −1 updated 08/07/20, 10:01

Commit message

New `SecurityUtility. getRandomHexValue(20)` returns 20 hexadecimal
characters provided by the Web Crypto API.

see https://developer.mozilla.org/en-US/docs/Web/API/Web_Crypto_API

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1114

  1. Oliver Hader uploaded patch set 1 07/17/20, 08:08

  2. TYPO3com voted on patch set 1 V +1 07/17/20, 08:20 Completed build in 11m 45s on Fri, 17 Jul, 08:20 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4120

  3. Oliver Klee commented on patch set 1 07/17/20, 09:33

    SecurityUtility.ts:30 Unresolved

    Do we need to issue a warning if the caller uses an odd length, resulting in a shorter result than expected?
  4. Oliver Hader voted on patch set 1 CR -1 07/17/20, 09:44

  5. Oliver Hader uploaded patch set 2 07/17/20, 09:53

  6. Oliver Hader commented on patch set 2 07/17/20, 09:55

    > Patch Set 1: > > (1 comment) Thx, that's a good catch. I've added some examples on how to test in console of the TYPO3 backend at the description for ticket #91809
  7. TYPO3com voted on patch set 2 V +1 07/17/20, 10:06 Completed build in 12m 26s on Fri, 17 Jul, 10:06 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4124

  8. Benni Mack voted on patch set 2 V +1 CR +1 08/05/20, 15:33

  9. Andreas Kienast commented on patch set 2 CR -1 08/06/20, 22:08

    I'll add some tests for this to check some basic stuff like negative inputs
  10. Andreas Kienast uploaded patch set 3 08/07/20, 06:34

  11. TYPO3com voted on patch set 3 V +1 08/07/20, 06:45 Completed build in 11m 20s on Fri, 7 Aug, 06:45 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4467

  12. Andreas Kienast voted on patch set 3 V +1 CR +1 08/07/20, 07:17

  13. Benni Mack voted on patch set 3 V +2 CR +2 08/07/20, 10:01

  14. Benni Mack merged patch set 4 08/07/20, 10:01