Review main Merged

65047[FEATURE] Introduce client-side templating engine

Oliver Hader CR +2 V +2 Hard +263 −0 updated 12/11/20, 13:51

Commit message

Introduce a slim and simplistic client-side templating engine to
avoid using custom template processing with e.g. jQuery and keep
results robust agains cross-site scripting.

This module has been inspired by `lit-html`, uses some of their
vocabulary and behavior, but actually does not have all of their
great features - see https://lit-element.polymer-project.org/

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1522

  1. Oliver Hader uploaded patch set 1 07/17/20, 08:09

  2. TYPO3com voted on patch set 1 V -1 07/17/20, 08:28 Completed build in 19m 17s on Fri, 17 Jul, 08:28 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4121

  3. Oliver Hader uploaded patch set 2 07/17/20, 09:40

  4. TYPO3com voted on patch set 2 V -1 07/17/20, 09:51 Completed build in 11m 11s on Fri, 17 Jul, 09:51 AM Test Summary: 72943 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4123

  5. Oliver Hader commented on patch set 2 07/17/20, 09:59

    Feature-91810-IntroduceClient-sideTemplatingEngine.rst:100 Unresolved

    `class=...` missing in result
  6. Oliver Hader uploaded patch set 3 07/17/20, 10:01

  7. TYPO3com voted on patch set 3 V -1 07/17/20, 10:13 Completed build in 11m 55s on Fri, 17 Jul, 10:13 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4125

  8. Oliver Hader rebased onto patch set 4 08/07/20, 16:31

  9. TYPO3com voted on patch set 4 V +1 08/07/20, 16:42 Completed build in 10m 59s on Fri, 7 Aug, 04:42 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4489

  10. Oliver Hader uploaded patch set 5 12/10/20, 20:40

  11. Oliver Hader marked it ready for review 12/10/20, 20:40

  12. Oliver Hader wrote 12/10/20, 20:40

    Topic set to javascript
  13. Oliver Hader uploaded patch set 6 12/10/20, 20:48

  14. TYPO3com voted on patch set 5 V +1 12/10/20, 20:51 Completed build in 10m 47s on Thu, 10 Dec, 08:51 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8032

  15. TYPO3com voted on patch set 6 V -1 12/10/20, 21:02 Completed build in 13m 33s on Thu, 10 Dec, 09:02 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8033

  16. TYPO3com voted on patch set 6 V +1 12/10/20, 21:11 Completed build in 36m 36s on Thu, 10 Dec, 09:11 PM Test Summary: 32412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8033

  17. Benni Mack voted on patch set 6 V +1 CR +1 12/10/20, 21:25

  18. Oli Bartsch voted on patch set 6 V +1 CR +1 12/10/20, 22:32

  19. Oliver Hader voted on patch set 6 V +2 CR +2 12/10/20, 22:34

  20. Oliver Hader merged patch set 7 12/10/20, 22:34

  21. Benjamin Franzke commented on patch set 7 12/11/20, 08:09

    lit-html is awesome, and in my opinion the future of client javascript templating. So it's good that we follow these principles. May I ask why we don't just use that library instead of adding our own one, that mimics lit-html? Adding lit-html would allow us to use LitElement as well. If it is really just that it is an ES6 module? Then an approach like https://review.typo3.org/c/Packages/TYPO3.CMS/+/65407 will solve that. I will try to come up with an approach before v11 to include lit-html converted to AMD. Hope you would be fine with that?
  22. Benjamin Franzke commented on patch set 7 12/11/20, 13:51

    Reply

    Here is a patch for integrating lit-html as AMD module: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67092 Preparatory revert for this patch is here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67095