65048[TASK] Replace FormEngine table wizard by custom element
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Richard Haeser +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Element/SpinnerElement.ts4new+66 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Element/TableWizardElement.ts1new+235 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/lit-helper.ts2+22 −2
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php2+13 −213
- typo3/sysext/backend/Classes/Form/FieldControl/TableWizard.php+3 −2
- typo3/sysext/backend/Resources/Public/JavaScript/Element/SpinnerElement.jsnew+44 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Element/TableWizardElement.jsnew+88 −0
- typo3/sysext/core/Resources/Public/JavaScript/lit-helper.js+1 −1
Review log 2332
Show 47 earlier messages
-
Oliver Hader uploaded patch set 1 07/17/20, 08:09
-
TYPO3com voted on patch set 1 V -1 07/17/20, 08:28 Completed build in 18m 29s on Fri, 17 Jul, 08:28 AM Test Summary: 7 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4122
-
Oliver Hader uploaded patch set 2 12/10/20, 22:58
-
Oliver Hader marked it ready for review 12/10/20, 22:59
-
TYPO3com voted on patch set 2 V -1 12/10/20, 23:23 Completed build in 17m 28s on Thu, 10 Dec, 11:23 PM Test Summary: 1 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8046
-
TYPO3com voted on patch set 2 V +1 12/11/20, 07:11 Completed build in 8h 23m 17s on Fri, 11 Dec, 07:11 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8046
-
Oliver Hader commented on patch set 2 CR -1 12/11/20, 07:30
LLL missing
-
Oliver Hader uploaded patch set 3 12/11/20, 14:45
-
Benjamin Franzke commented on patch set 3 CR -2 12/11/20, 14:49
I like this change a lot. Thank you. I would like to see this rebased on lit-html. Therefore blocking merge in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/67095 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/67092 -
Benjamin Franzke commented on patch set 3 12/11/20, 14:50
Reply
BTW: I'm willing to take care of rebasing this. -
TYPO3com voted on patch set 3 V -1 12/11/20, 14:56 Completed build in 10m 17s on Fri, 11 Dec, 02:56 PM Test Summary: 1 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8079
-
TYPO3com voted on patch set 3 V +1 12/11/20, 15:03 Completed build in 27m 43s on Fri, 11 Dec, 03:03 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8079
-
Benjamin Franzke commented on patch set 3 12/12/20, 11:25
Reply
Prepared a rebase on lit-element here: https://github.com/bnf/TYPO3.CMS/commit/lit-element-formengine-wizard-v1 Pretty straight forward. Most import is that we can use properties instead of attributes for <input> and <textarea>, which means we do not need to sanizize HTML, but let the browser do the work. The upper left expand icon wasn't rendering before (<span… was printed as text), therefore I added an `unsafeHTML` there.. -
Benjamin Franzke uploaded patch set 4 12/18/20, 07:11
-
Benjamin Franzke commented on patch set 4 12/18/20, 07:11
Reply
pushed.TableWizardElement.ts:117typo: textarea -
TYPO3com voted on patch set 4 V +1 12/18/20, 07:19 Completed build in 08m 32s on Fri, 18 Dec, 07:19 AM Test Summary: 32495 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8242
-
Oliver Hader commented on patch set 4 CR -1 12/18/20, 08:42
Checking/Trying some things again -
Oliver Hader uploaded patch set 5 12/18/20, 12:37
-
Oliver Hader uploaded patch set 6 12/18/20, 12:40
-
TYPO3com voted on patch set 5 V +1 12/18/20, 12:46 Completed build in 08m 24s on Fri, 18 Dec, 12:46 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8250
-
TYPO3com voted on patch set 6 V +1 12/18/20, 12:49 Completed build in 08m 21s on Fri, 18 Dec, 12:49 PM Test Summary: 32495 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8251
-
Oliver Hader wrote 12/18/20, 12:53
Topic set to inline-javascript -
Benjamin Franzke commented on patch set 6 CR -1 12/18/20, 13:16
lit-helper.ts:36Hm, we should always import element dependencies via typescript, that's also common practice for web components in generall. Let's add import 'TYPO3/CMS/Backend/Element/SpinnerElement' to lit-helper.ts, or rather move `icon()` into a separate module, if we don't want SpinnerElement to be loaded "too often".TableController.php:122Let's remove this here and rather add this as dependency to lit-helper. -
Benjamin Franzke commented on patch set 6 12/18/20, 13:20
SpinnerElement.ts:30As far as I know, only :host is needed here. The selector typo3-backend-spinner would only have effect on elements inside the shadow dom – or is that needed for browsers (compat?)? But +1 for using shadow dom 😊 -
Benjamin Franzke uploaded patch set 7 12/18/20, 18:40
-
Benjamin Franzke commented on patch set 7 12/18/20, 18:40
SpinnerElement.ts:30ReplyDonelit-helper.ts:36ReplyDoneTableController.php:122ReplyDone -
Richard Haeser voted on patch set 7 V +1 CR +1 12/18/20, 18:46
-
TYPO3com voted on patch set 7 V +1 12/18/20, 18:49 Completed build in 09m 13s on Fri, 18 Dec, 06:49 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8262
-
Benjamin Franzke voted on patch set 7 V +2 CR +2 12/18/20, 19:01
-
Benjamin Franzke merged patch set 8 12/18/20, 19:04
-
Oliver Hader commented on patch set 8 12/18/20, 19:22
Thx for merging this 😊SpinnerElement.ts:30ReplyCorrect, that was a left-over since I was playing around with open/light/shadow DOM... And in the end it was shadow DOM since this component does not have any other dependencies -
Oliver Hader commented on patch set 8 12/19/20, 11:11
SpinnerElement.ts:53UnresolvedProbably should have used other units here, e.g. `em` instead of `px`