Review main Merged

65048[TASK] Replace FormEngine table wizard by custom element

Oliver Hader CR +2 V +2 Hard +472 −218 updated 12/19/20, 11:11

Commit message

The FormEngine table wizard in the backend is replace by
a HTML custom element which allows to avoid server-side
round-trips when manipulating table rows and columns.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 2332

Show 47 earlier messages
  1. Oliver Hader uploaded patch set 1 07/17/20, 08:09

  2. TYPO3com voted on patch set 1 V -1 07/17/20, 08:28 Completed build in 18m 29s on Fri, 17 Jul, 08:28 AM Test Summary: 7 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4122

  3. Oliver Hader uploaded patch set 2 12/10/20, 22:58

  4. Oliver Hader marked it ready for review 12/10/20, 22:59

  5. TYPO3com voted on patch set 2 V -1 12/10/20, 23:23 Completed build in 17m 28s on Thu, 10 Dec, 11:23 PM Test Summary: 1 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8046

  6. TYPO3com voted on patch set 2 V +1 12/11/20, 07:11 Completed build in 8h 23m 17s on Fri, 11 Dec, 07:11 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8046

  7. Oliver Hader commented on patch set 2 CR -1 12/11/20, 07:30

    LLL missing
  1. Oliver Hader uploaded patch set 3 12/11/20, 14:45

  2. Benjamin Franzke commented on patch set 3 CR -2 12/11/20, 14:49

    I like this change a lot. Thank you. I would like to see this rebased on lit-html. Therefore blocking merge in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/67095 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/67092
  3. Benjamin Franzke commented on patch set 3 12/11/20, 14:50

    Reply

    BTW: I'm willing to take care of rebasing this.
  4. TYPO3com voted on patch set 3 V -1 12/11/20, 14:56 Completed build in 10m 17s on Fri, 11 Dec, 02:56 PM Test Summary: 1 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8079

  5. TYPO3com voted on patch set 3 V +1 12/11/20, 15:03 Completed build in 27m 43s on Fri, 11 Dec, 03:03 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8079

  6. Benjamin Franzke commented on patch set 3 12/12/20, 11:25

    Reply

    Prepared a rebase on lit-element here: https://github.com/bnf/TYPO3.CMS/commit/lit-element-formengine-wizard-v1 Pretty straight forward. Most import is that we can use properties instead of attributes for <input> and <textarea>, which means we do not need to sanizize HTML, but let the browser do the work. The upper left expand icon wasn't rendering before (<span… was printed as text), therefore I added an `unsafeHTML` there..
  7. Benjamin Franzke uploaded patch set 4 12/18/20, 07:11

  8. Benjamin Franzke commented on patch set 4 12/18/20, 07:11

    Reply

    pushed.

    TableWizardElement.ts:117

    typo: textarea
  9. TYPO3com voted on patch set 4 V +1 12/18/20, 07:19 Completed build in 08m 32s on Fri, 18 Dec, 07:19 AM Test Summary: 32495 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8242

  10. Oliver Hader commented on patch set 4 CR -1 12/18/20, 08:42

    Checking/Trying some things again
  11. Oliver Hader uploaded patch set 5 12/18/20, 12:37

  12. Oliver Hader uploaded patch set 6 12/18/20, 12:40

  13. TYPO3com voted on patch set 5 V +1 12/18/20, 12:46 Completed build in 08m 24s on Fri, 18 Dec, 12:46 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8250

  14. TYPO3com voted on patch set 6 V +1 12/18/20, 12:49 Completed build in 08m 21s on Fri, 18 Dec, 12:49 PM Test Summary: 32495 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8251

  15. Oliver Hader wrote 12/18/20, 12:53

    Topic set to inline-javascript
  16. Benjamin Franzke commented on patch set 6 CR -1 12/18/20, 13:16

    lit-helper.ts:36

    Hm, we should always import element dependencies via typescript, that's also common practice for web components in generall. Let's add import 'TYPO3/CMS/Backend/Element/SpinnerElement' to lit-helper.ts, or rather move `icon()` into a separate module, if we don't want SpinnerElement to be loaded "too often".

    TableController.php:122

    Let's remove this here and rather add this as dependency to lit-helper.
  17. Benjamin Franzke commented on patch set 6 12/18/20, 13:20

    SpinnerElement.ts:30

    As far as I know, only :host is needed here. The selector typo3-backend-spinner would only have effect on elements inside the shadow dom – or is that needed for browsers (compat?)? But +1 for using shadow dom 😊
  18. Benjamin Franzke uploaded patch set 7 12/18/20, 18:40

  19. Benjamin Franzke commented on patch set 7 12/18/20, 18:40

    SpinnerElement.ts:30 Reply

    Done

    lit-helper.ts:36 Reply

    Done

    TableController.php:122 Reply

    Done
  20. Richard Haeser voted on patch set 7 V +1 CR +1 12/18/20, 18:46

  21. TYPO3com voted on patch set 7 V +1 12/18/20, 18:49 Completed build in 09m 13s on Fri, 18 Dec, 06:49 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8262

  22. Benjamin Franzke voted on patch set 7 V +2 CR +2 12/18/20, 19:01

  23. Benjamin Franzke merged patch set 8 12/18/20, 19:04

  24. Oliver Hader commented on patch set 8 12/18/20, 19:22

    Thx for merging this 😊

    SpinnerElement.ts:30 Reply

    Correct, that was a left-over since I was playing around with open/light/shadow DOM... And in the end it was shadow DOM since this component does not have any other dependencies
  25. Oliver Hader commented on patch set 8 12/19/20, 11:11

    SpinnerElement.ts:53 Unresolved

    Probably should have used other units here, e.g. `em` instead of `px`