Review 10.4 Merged

65049[TASK] Add possibility to create random values in JavaScript

Oliver Hader CR +2 V +2 Normal +65 −1 updated 08/07/20, 10:01

Commit message

New `SecurityUtility. getRandomHexValue(20)` returns 20 hexadecimal
characters provided by the Web Crypto API.

see https://developer.mozilla.org/en-US/docs/Web/API/Web_Crypto_API

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 912

  1. Oliver Hader uploaded patch set 1 07/17/20, 10:03

  2. TYPO3com voted on patch set 1 V +1 07/17/20, 10:14 Completed build in 11m 12s on Fri, 17 Jul, 10:14 AM Test Summary: 73889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-90

  3. Daniel Goerz voted on patch set 1 V +1 CR +1 07/20/20, 18:56

  4. Oliver Hader rebased onto patch set 2 07/28/20, 07:17

  5. TYPO3com voted on patch set 2 V +1 07/28/20, 07:29 Completed build in 11m 38s on Tue, 28 Jul, 07:29 AM Test Summary: 73989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-126

  6. Christian Kuhn voted on patch set 2 CR +1 08/06/20, 15:27

  7. Andreas Kienast commented on patch set 2 CR -1 08/06/20, 22:02

    I'll add some tests for this
  8. Oliver Hader commented on patch set 2 08/06/20, 22:02

    Awesome, thx!
  9. Andreas Kienast uploaded patch set 3 08/07/20, 07:21

  10. TYPO3com voted on patch set 3 V +1 08/07/20, 07:34 Completed build in 12m 50s on Fri, 7 Aug, 07:34 AM Test Summary: 74021 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-182

  11. Benni Mack voted on patch set 3 V +2 CR +2 08/07/20, 10:01

  12. Benni Mack merged patch set 4 08/07/20, 10:01