65050[TASK] Remove window.open inline JavaScript in backend
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Login.ts+11 −0
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+11 −13
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −6
- typo3/sysext/backend/Resources/Public/Html/Close.html+1 −4
- typo3/sysext/backend/Resources/Public/Html/Close.jsnew+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Login.js+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/LoginControllerTest.php+0 −89
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+8 −1
Review log 711
-
Oliver Hader uploaded patch set 1 07/17/20, 11:53
-
TYPO3com voted on patch set 1 V -1 07/17/20, 11:54 Completed build in 28s on Fri, 17 Jul, 11:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4126
-
Oliver Hader uploaded patch set 2 07/17/20, 12:10
-
TYPO3com voted on patch set 2 V -1 07/17/20, 12:27 Completed build in 16m 25s on Fri, 17 Jul, 12:27 PM Test Summary: 12 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4129
-
Oliver Hader uploaded patch set 3 07/17/20, 12:42
-
TYPO3com voted on patch set 3 V +1 07/17/20, 12:54 Completed build in 12m 05s on Fri, 17 Jul, 12:54 PM Test Summary: 72933 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4131
-
Benni Mack uploaded patch set 4 07/06/21, 13:26
-
Benni Mack voted on patch set 4 V +1 CR +1 07/06/21, 13:26
-
core-ci voted on patch set 4 V +1 07/06/21, 13:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13011
-
Andreas Kienast voted on patch set 4 V +2 CR +2 07/09/21, 07:58
-
Andreas Kienast merged patch set 5 07/09/21, 07:58