Review main Merged

65050[TASK] Remove window.open inline JavaScript in backend

Oliver Hader CR +2 V +2 Normal +35 −114 updated 07/09/21, 07:58

Commit message

To reduce the amount of inline JavaScript corresponding `window.open`
occurrences are removed from TYPO3 backend user interface:

* Backend Login refresh handling
  + tests checking for arbitrary inline JavaScript were removed
* ViewPage page preview
* FormEngine
  + "open in new window" button in top right bar
  + close behavior when editing form in new window

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 711

  1. Oliver Hader uploaded patch set 1 07/17/20, 11:53

  2. TYPO3com voted on patch set 1 V -1 07/17/20, 11:54 Completed build in 28s on Fri, 17 Jul, 11:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4126

  3. Oliver Hader uploaded patch set 2 07/17/20, 12:10

  4. TYPO3com voted on patch set 2 V -1 07/17/20, 12:27 Completed build in 16m 25s on Fri, 17 Jul, 12:27 PM Test Summary: 12 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4129

  5. Oliver Hader uploaded patch set 3 07/17/20, 12:42

  6. TYPO3com voted on patch set 3 V +1 07/17/20, 12:54 Completed build in 12m 05s on Fri, 17 Jul, 12:54 PM Test Summary: 72933 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4131

  7. Benni Mack uploaded patch set 4 07/06/21, 13:26

  8. Benni Mack voted on patch set 4 V +1 CR +1 07/06/21, 13:26

  9. core-ci voted on patch set 4 V +1 07/06/21, 13:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13011

  10. Andreas Kienast voted on patch set 4 V +2 CR +2 07/09/21, 07:58

  11. Andreas Kienast merged patch set 5 07/09/21, 07:58