65052[TASK] Avoid inline JavaScript generated by BackendUtility:viewOnClick
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 36
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Element/ImmediateActionElement.ts+16 −3
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ActionDispatcher.ts+5 −11
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Utility.ts+14 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/WindowManager.tsnew+63 −0
- Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Backend.ts+7 −6
- Build/types/TYPO3/index.d.ts+1 −0
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+5 −2
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+5 −1
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+5 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php2+19 −38
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+5 −5
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+6 −9
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.phpnew+324 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −0
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/LanguageColumn.php+7 −9
- typo3/sysext/backend/Classes/View/PageLayoutView.php+6 −9
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/ElementInformation.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Element/ImmediateActionElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ActionDispatcher.js+1 −1
Show 16 more files
- typo3/sysext/backend/Resources/Public/JavaScript/Utility.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/WindowManager.jsnew+13 −0
- typo3/sysext/backend/Tests/Unit/Routing/PreviewUriBuilderTest.phpnew+49 −0
- typo3/sysext/core/Documentation/Changelog/10.4.x/Important-91123-AvoidUsingBackendUtilityViewOnClick.rstnew+59 −0
- typo3/sysext/impexp/Classes/Controller/ImportController.php+5 −6
- typo3/sysext/impexp/Classes/ImportExport.php+4 −2
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+5 −5
- typo3/sysext/info/Classes/Controller/PageInformationController.php+5 −3
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+8 −20
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+22 −29
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+5 −5
- typo3/sysext/workspaces/Classes/Event/RetrievedPreviewUrlEvent.phpnew+110 −0
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+39 −24
- typo3/sysext/workspaces/Configuration/Services.yaml+7 −0
- typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js+1 −1
Review log 914
-
Oliver Hader uploaded patch set 1 07/17/20, 12:05
-
TYPO3com voted on patch set 1 V +1 07/17/20, 12:19 Completed build in 14m 13s on Fri, 17 Jul, 12:19 PM Test Summary: 73896 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-91
-
Oliver Klee commented on patch set 1 07/17/20, 13:35
-
Oliver Hader voted on patch set 1 CR -1 07/17/20, 14:37
-
Oliver Hader uploaded patch set 2 07/17/20, 14:39
-
Oliver Hader commented on patch set 2 07/17/20, 14:42
Looking forward to reviews & tests (with actual votes), thx!EditDocumentController.php:192ReplyDone -
TYPO3com voted on patch set 2 V -1 07/17/20, 14:52 Completed build in 13m 03s on Fri, 17 Jul, 02:52 PM Test Summary: 1 of 74380 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-94
-
TYPO3com voted on patch set 2 V +1 07/17/20, 15:09 Completed build in 42m 43s on Fri, 17 Jul, 03:09 PM Test Summary: 73896 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-94
-
Andreas Kienast uploaded patch set 3 08/06/20, 08:25
-
TYPO3com voted on patch set 3 V +1 08/06/20, 08:36 Completed build in 11m 42s on Thu, 6 Aug, 08:36 AM Test Summary: 74001 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-169
-
Andreas Kienast uploaded patch set 4 08/08/20, 13:49
-
TYPO3com voted on patch set 4 V +1 08/08/20, 14:17 Completed build in 15m 28s on Sat, 8 Aug, 02:17 PM Test Summary: 74015 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-188
-
Oliver Klee wrote 08/08/20, 15:27
Removed reviewer Oliver Klee. -
Oliver Hader abandoned the change 12/03/20, 19:19
Giving up for 10.4
EditDocumentController.php:192