Review main Merged

65055[TASK] Remove inline onclick code from MoveElementController

Oliver Hader CR +2 V +2 Easy +3 −4 updated 08/15/20, 14:21

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Windloff +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Windloff +1
    • Christian Kuhn +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1114

  1. Oliver Hader uploaded patch set 1 07/17/20, 14:43

  2. Oliver Hader wrote 07/17/20, 14:43

    Topic set to inline-javascript
  3. TYPO3com voted on patch set 1 V -1 07/17/20, 15:01 Completed build in 16m 33s on Fri, 17 Jul, 03:01 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4136

  4. TYPO3com commented on patch set 1 07/17/20, 15:06 Completed build in 37m 58s on Fri, 17 Jul, 03:06 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4136

  5. Oliver Hader uploaded patch set 2 07/17/20, 15:12

  6. Oliver Hader commented on patch set 2 07/17/20, 15:13

    MoveElement.html:6

    "Expected an indentation at 16 instead of at 15"... whatever...
  7. TYPO3com voted on patch set 2 V +1 07/17/20, 15:23 Completed build in 11m 11s on Fri, 17 Jul, 03:23 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4138

  8. Benni Mack voted on patch set 2 V +1 CR +1 08/05/20, 15:28

  9. Oliver Hader commented on patch set 2 08/10/20, 20:23

    MoveElement.html:6 Reply

    Done
  10. Oliver Klee voted on patch set 2 CR +1 08/14/20, 09:29

  11. Daniel Windloff commented on patch set 2 V +1 CR +1 08/14/20, 15:29

    Test cp and mv
  12. Christian Kuhn voted on patch set 2 V +1 CR +1 08/15/20, 14:21

  13. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/15/20, 14:21

  14. Anja Leichsenring merged patch set 3 08/15/20, 14:21