65056[BUGFIX] Fix indenting in changelog
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 31
- typo3/sysext/core/Documentation/Changelog/7.1/Breaking-64637-CSSStyledContentLegacyTypoScriptRemoved.rst+5 −5
- typo3/sysext/core/Documentation/Changelog/7.2/Breaking-56746-AddCountMethodsAndSortFunctionalityToFalDrivers.rst+4 −4
- typo3/sysext/core/Documentation/Changelog/7.2/Breaking-64719-MediaContentMovedToSystemExtension.rst+5 −5
- typo3/sysext/core/Documentation/Changelog/7.2/Breaking-65727-DontProvideAccessToLocalpathOfFalFiles.rst+5 −5
- typo3/sysext/core/Documentation/Changelog/7.2/Breaking-66286-PageTSconfigOptionsToHideWebInfoModulesRenamed.rst+7 −7
- typo3/sysext/core/Documentation/Changelog/7.3/Feature-59606-IntegrateSymfonyConsoleIntoCommandController.rst+49 −49
- typo3/sysext/core/Documentation/Changelog/7.5/Breaking-69028-DropNegForeignTable.rst+5 −5
- typo3/sysext/core/Documentation/Changelog/7.5/Deprecation-55419-StreamlineFileConflictModeHandling.rst+7 −7
- typo3/sysext/core/Documentation/Changelog/7.6/Breaking-66369-RemovedElementBrowserRelatedClasses.rst+5 −5
- typo3/sysext/core/Documentation/Changelog/7.6/Feature-66369-AddedLinkBrowserAPIs.rst+2 −2
- typo3/sysext/core/Documentation/Changelog/8.0/Breaking-72572-RemoveMoreDeprecatedMiscellaneousFunctionsAndOptions.rst+8 −8
- typo3/sysext/core/Documentation/Changelog/8.0/Breaking-72686-RemovedRteHtmlParserMethods.rst+4 −4
- typo3/sysext/core/Documentation/Changelog/8.0/Breaking-72826-RemovedCustomCharsetConfigurationForLocales.rst+5 −5
- typo3/sysext/core/Documentation/Changelog/8.0/Breaking-72853-RemoveUnusedImagesFromCore.rst+77 −75
- typo3/sysext/core/Documentation/Changelog/8.0/Breaking-72888-RemovedHtmlParserMapTagsFunctionality.rst+2 −2
- typo3/sysext/core/Documentation/Changelog/8.1/Breaking-70056-CurlAndHttpRequestRemoved.rst+31 −31
- typo3/sysext/core/Documentation/Changelog/8.1/Deprecation-75371-Array2xml_cs.rst+2 −2
- typo3/sysext/core/Documentation/Changelog/8.3/Breaking-77460-ExtbaseQueryCacheRemoved.rst+4 −4
- typo3/sysext/core/Documentation/Changelog/8.5/Important-78383-TCAStreamlineFieldPositionsInTabsForRecurringFields.rst+2 −2
- typo3/sysext/core/Documentation/Changelog/8.6/Breaking-79464-ExtFormRefactorFluidRendering.rst+35 −15
Show 11 more files
- typo3/sysext/core/Documentation/Changelog/8.6/Feature-47006-ExtendTheWidgetIdentifierWithCustomString.rst+2 −1
- typo3/sysext/core/Documentation/Changelog/8.6/Feature-78169-IntroduceTranslationSourceFieldForTt_content.rst+6 −6
- typo3/sysext/core/Documentation/Changelog/8.6/Feature-78192-RefactorClickMenuContextMenu.rst+7 −7
- typo3/sysext/core/Documentation/Changelog/9.0/Breaking-82768-ConfigurationOptionsForImageManipulationPHPAPI.rst+17 −17
- typo3/sysext/core/Documentation/Changelog/9.0/Deprecation-82975-DeprecateUsageOfInjectWithNonPublicProperties.rst+3 −3
- typo3/sysext/core/Documentation/Changelog/9.4/Deprecation-83750-AdaptTCASignatureForInlineCustomControl.rst+2 −0
- typo3/sysext/core/Documentation/Changelog/9.5/Feature-86365-RoutingEnhancersAndAspects.rst+7 −7
- typo3/sysext/core/Documentation/Changelog/10.0/Feature-84112-SymfonyDependencyInjectionForCoreAndExtbase.rst+15 −15
- typo3/sysext/core/Documentation/Changelog/10.2/Deprecation-89718-LegacyPageTSconfigParsingLowlevelAPI.rst2+11 −12
- typo3/sysext/core/Documentation/Changelog/10.2/Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst+4 −8
- typo3/sysext/core/Documentation/Changelog/10.2/Important-89764-IncompatibleEnvironmentRelatedDependencyInjectionServicesHaveBeenRemoved.rst+4 −4
Review log 1317
-
Sybille Peters uploaded patch set 1 07/17/20, 17:58
-
TYPO3com voted on patch set 1 V +1 07/17/20, 18:09 Completed build in 11m 21s on Fri, 17 Jul, 06:09 PM Test Summary: 72944 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4144
-
Sybille Peters uploaded patch set 2 07/18/20, 13:30
-
TYPO3com voted on patch set 2 V +1 07/18/20, 13:42 Completed build in 11m 39s on Sat, 18 Jul, 01:41 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4151
-
Tomas Norre Mikkelsen commented on patch set 2 07/19/20, 07:45
Why are you removed the code-block formating like html and php ?Deprecation-89718-LegacyPageTSconfigParsingLowlevelAPI.rst:56Why isn't the :php: highlightning not relevant anymore? -
Tomas Norre Mikkelsen commented on patch set 2 07/19/20, 07:46
Why are you removing the codeblock style like html and php -
Sybille Peters commented on patch set 2 07/19/20, 08:02
> Patch Set 2: > > (1 comment) > > Why are you removed the code-block formating like html and php ?Deprecation-89718-LegacyPageTSconfigParsingLowlevelAPI.rst:56Reply UnresolvedIt is relevant. But PHP highlighting is the default. The default is defined by 1) Includes.txt 2) highlight directive on the page 3) ..code-block:: language 2 overrides 1, 3 overrides 2. The current code is incorrect. :php: can be used as textrole for inline code, but then the following inline code must be enclosed in backticks. The current cordeblock is simply incorrect and will not render correctly, see https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.2/Deprecation-89718-LegacyPageTSconfigParsingLowlevelAPI.html#migration -
Sybille Peters commented on patch set 2 07/19/20, 08:07
Clarification: The following is specified in Includes.txt: .. highlight:: PHP (This can differ in a documentation project, e.g. for TSref it is TypoScript. For the core it is PHP. You can also use lowercase php.). This can also be overridden in a documentation .rst file (using the same directive). When this is used, we can use the shorthand :: for code-blocks and do not have to specify the language. For code blocks, you can either use `::` or `.. code-block` :php: is used for inline code with backticks. see: * https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/WritingReST/InlineCode.html * https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/WritingReST/Codeblocks.html See also the hints on the forger Changelog generator: https://forger.typo3.com/utilities/rst -
Sybille Peters commented on patch set 2 07/19/20, 11:06
> Patch Set 2: > > (1 comment) > > Why are you removed the code-block formating like html and php ? This may refer to several changes where I changed things for different reasons. If this does not answer your question, please make a comment in the code. These are the changes to which this might refer to. 1. code-block AND :: existed which is duplicate and resulted in broken rendering, see https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.2/Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.html#description https://review.typo3.org/c/Packages/TYPO3.CMS/+/65056/2/typo3/sysext/core/Documentation/Changelog/10.2/Feature-88950-AddStoreSessionArgumentToWidgetViewHelpers.rst I also changed the language from HTML to XML. Explicitly stating the language there is not necessary because the file already contains a highlight directive (explained in the previous comment). That is why I removed the .. code-block but not the :: 2. See previous comment about :php: 3. ? Not sure if it was changed anywhere else. -
Daniel Goerz commented on patch set 2 V +1 CR +1 07/20/20, 18:35
> Patch Set 2: > > (1 comment) > > > Patch Set 2: > > > > (1 comment) > > > > Why are you removed the code-block formating like html and php ? -
Benni Mack updated the commit message in patch set 3 07/21/20, 06:45
-
Benni Mack updated the commit message in patch set 4 07/21/20, 06:45
-
Benni Mack voted on patch set 4 V +1 CR +1 07/21/20, 06:45
-
TYPO3com voted on patch set 3 V +1 07/21/20, 06:59 Completed build in 13m 33s on Tue, 21 Jul, 06:59 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4166
-
Daniel Goerz voted on patch set 4 V +2 CR +2 07/21/20, 07:01
-
TYPO3com voted on patch set 4 V +1 07/21/20, 07:02 Completed build in 16m 12s on Tue, 21 Jul, 07:02 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4167
-
Daniel Goerz merged patch set 5 07/21/20, 07:03