Review main Abandoned

65057[BUGFIX] Change DECIMAL values in ext_tables.sql for sysext/seo

Tomas Norre Mikkelsen CR 0 V 0 Normal +80 −1 updated 07/24/20, 09:54

Commit message

This patch ensures that all values in the sysext/seo range from 0.0 to
1.0 can be added to the database.

Without this patch the 1.0 will throw an error:
SQL error: 'Out of range value for column 'sitemap_priority' at row 1'

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 810

  1. Tomas Norre Mikkelsen uploaded patch set 1 07/18/20, 09:23

  2. TYPO3com voted on patch set 1 V -1 07/18/20, 09:23 Completed build in 23s on Sat, 18 Jul, 09:23 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4149

  3. Tomas Norre Mikkelsen commented on patch set 1 07/18/20, 09:25

    > Patch Set 1: Verified-1 > > Completed build in 23s on Sat, 18 Jul, 09:23 AM > Test Summary: No tests found > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4149 I don't get why it says no test found. I have added tests to ensure that the bug is fixed.
  4. Oliver Klee updated the commit message in patch set 2 07/18/20, 12:38

  5. TYPO3com voted on patch set 2 V -1 07/18/20, 12:38 Completed build in 22s on Sat, 18 Jul, 12:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4150

  6. Andreas Kienast commented on patch set 2 07/19/20, 17:24

    > Patch Set 1: > I don't get why it says no test found. I have added tests to ensure that the bug is fixed. The CGL job fails in a previous stage, that's why no test are found - no tests are executed.
  7. Tomas Norre Mikkelsen commented on patch set 2 07/19/20, 17:50

    > The CGL job fails in a previous stage, that's why no test are found - no tests are executed. My bad, haven't seen that. Will push a new patch-set tomorrow. Thanks
  8. Benni Mack commented on patch set 2 07/20/20, 04:08

    There is a similar change already here... https://review.typo3.org/c/Packages/TYPO3.CMS/+/64993
  9. Tomas Norre Mikkelsen commented on patch set 2 07/20/20, 05:26

    > Patch Set 2: > > There is a similar change already here... https://review.typo3.org/c/Packages/TYPO3.CMS/+/64993 Then I'll suggest to close this one, and marked as duplicate.
  10. Daniel Goerz abandoned the change 07/24/20, 09:54