Review main Merged

65058[BUGFIX] Prevent toggling of child containers controls

Nikita Hovratov CR +2 V +2 Easy +5 −4 updated 09/18/20, 07:39

Commit message

The toggleContainerControls method of InlineControlContainer.ts now
only toggles its immediate controls. Furthermore, the new record link
control for creating inline records has gotten the required class to
toggle its visibility, when reaching maxitems limit.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1116

  1. Nikita Hovratov uploaded patch set 1 07/18/20, 20:56

  2. Nikita Hovratov updated the commit message in patch set 2 07/18/20, 20:57

  3. TYPO3com voted on patch set 1 V +1 07/18/20, 21:09 Completed build in 12m 14s on Sat, 18 Jul, 09:09 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4152

  4. TYPO3com voted on patch set 2 V +1 07/18/20, 21:12 Completed build in 14m 06s on Sat, 18 Jul, 09:12 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4153

  5. Oli Bartsch uploaded patch set 3 08/13/20, 13:19

  6. Oli Bartsch voted on patch set 3 V +1 08/13/20, 13:24

  7. TYPO3com voted on patch set 3 V +1 08/13/20, 13:34 Completed build in 14m 26s on Thu, 13 Aug, 01:34 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4628

  8. Nikita Hovratov uploaded patch set 4 09/02/20, 12:07

  9. TYPO3com voted on patch set 4 V -1 09/02/20, 12:18 Completed build in 11m 08s on Wed, 2 Sep, 12:18 PM Test Summary: 11 of 73649 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5139

  10. Nikita Hovratov uploaded patch set 5 09/02/20, 12:23

  11. TYPO3com voted on patch set 5 V +1 09/02/20, 12:35 Completed build in 12m 02s on Wed, 2 Sep, 12:35 PM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5141

  12. Anja Leichsenring voted on patch set 5 V +1 CR +1 09/02/20, 18:40

  13. Oli Bartsch voted on patch set 5 V +1 CR +1 09/02/20, 20:27

  14. Anja Leichsenring commented on patch set 5 09/17/20, 19:26

    I created a styleguide example for the issue: https://github.com/TYPO3/styleguide/pull/159
  15. Benni Mack voted on patch set 5 V +2 CR +2 09/18/20, 07:39

  16. Benni Mack merged patch set 6 09/18/20, 07:39