Review main Merged

65059[BUGFIX] Only localize inline records that are not translated

Torben Hansen CR +2 V +2 Hard +257 −0 updated 03/28/21, 18:49

Commit message

This patch ensures that DataHandler does not try to localize inline
records that already have a translation for the given language.

With the change, no confusing error message is shown to the editor
when the "Localize all records" or "Synchronize with original language"
action is used in inline elements.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 2033

Show 58 earlier messages
  1. Torben Hansen uploaded patch set 1 07/20/20, 12:50

  2. TYPO3com voted on patch set 1 V -1 07/20/20, 13:02 Completed build in 11m 14s on Mon, 20 Jul, 01:02 PM Test Summary: 72944 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4156

  3. Oliver Klee updated the commit message in patch set 2 07/20/20, 15:46

  4. Oliver Klee commented on patch set 2 07/20/20, 15:46

    Can we cover this with tests?
  5. TYPO3com voted on patch set 2 V -1 07/20/20, 15:58 Completed build in 11m 29s on Mon, 20 Jul, 03:58 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4158

  6. Torben Hansen uploaded patch set 3 07/22/20, 18:15

  7. TYPO3com voted on patch set 3 V +1 07/22/20, 18:27 Completed build in 11m 22s on Wed, 22 Jul, 06:27 PM Test Summary: 72909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4196

  8. Oliver Klee updated the commit message in patch set 4 07/22/20, 20:44

  1. TYPO3com voted on patch set 4 V -1 07/22/20, 20:57 Completed build in 12m 08s on Wed, 22 Jul, 08:57 PM Test Summary: 1 of 73396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4197

  2. Torben Hansen rebased onto patch set 5 08/08/20, 12:09

  3. TYPO3com voted on patch set 5 V +1 08/08/20, 12:20 Completed build in 11m 14s on Sat, 8 Aug, 12:20 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4491

  4. Claus Due commented on patch set 5 CR -1 08/08/20, 14:58

    DataHandler.php:4583

    Would be great to refactor this, so we pull a full list of all child records + all translated child records and use the diff of that array - instead of pulling individual child records. As it is now, the check here will perform 2 additional DB fetches for each related record - we could reduce this to 2 fetches that select multiple records/overlays. This may cascade to many, many fetches which may not be desirable.
  5. Oliver Klee wrote 08/08/20, 15:28

    Removed reviewer Oliver Klee.
  6. Christian Kuhn rebased onto patch set 6 03/25/21, 14:26

  7. Christian Kuhn commented on patch set 6 CR -1 03/25/21, 14:26

    working on it, rebased for now.
  8. TYPO3com voted on patch set 6 V +1 03/25/21, 14:33 Completed build in 06m 48s on Thu, 25 Mar, 02:33 PM Test Summary: 33212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10349

  9. core-ci voted on patch set 6 V +1 03/25/21, 14:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1836

  10. Christian Kuhn uploaded patch set 7 03/25/21, 16:42

  11. Christian Kuhn voted on patch set 7 CR -1 03/25/21, 16:43

  12. TYPO3com voted on patch set 7 V -1 03/25/21, 16:49 Completed build in 06m 52s on Thu, 25 Mar, 04:49 PM Test Summary: 33215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10350

  13. core-ci voted on patch set 7 V -1 03/25/21, 16:52 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1837

  14. Christian Kuhn commented on patch set 7 03/25/21, 17:25

    DataHandler.php:4583 Reply

    this is (currently) not easily do-able due to the workspace related overlay logic that is based on single records: that topic is broader and can't be solved with this bugfix patch easily. I'd thus go with the proposed solution for now.
  15. Christian Kuhn commented on patch set 7 03/25/21, 17:26

    DataHandler.php:4583 Reply

    Done
  16. Christian Kuhn uploaded patch set 8 03/25/21, 17:32

  17. Christian Kuhn updated the commit message in patch set 9 03/25/21, 17:35

  18. TYPO3com voted on patch set 8 V +1 03/25/21, 17:39 Completed build in 07m 01s on Thu, 25 Mar, 05:39 PM Test Summary: 33245 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10352

  19. TYPO3com voted on patch set 9 V +1 03/25/21, 17:42 Completed build in 07m 24s on Thu, 25 Mar, 05:42 PM Test Summary: 33245 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10353

  20. core-ci voted on patch set 8 V +1 03/25/21, 17:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1839

  21. core-ci voted on patch set 9 V +1 03/25/21, 17:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1840

  22. Christian Kuhn voted on patch set 9 V +1 CR +1 03/25/21, 17:47

  23. Oli Bartsch voted on patch set 9 V +1 CR +1 03/26/21, 19:27

  24. Benni Mack voted on patch set 9 V +2 CR +2 03/28/21, 18:49

  25. Benni Mack merged patch set 10 03/28/21, 18:49