Review main Merged

65060[BUGFIX] Correctly render information boxes if image rendering tests fail

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 07/21/20, 09:21

Commit message

Due to a naming mismatch in the refactoring during #87724 it was tried to
render information boxes based on the parent container element.

The code is adjusted now to reference the correct object in the
rendering loop.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 710

  1. Andreas Kienast uploaded patch set 1 07/20/20, 16:46

  2. Andreas Kienast updated the commit message in patch set 2 07/20/20, 16:47

  3. Andreas Kienast updated the commit message in patch set 3 07/20/20, 16:50

  4. TYPO3com voted on patch set 1 V +1 07/20/20, 16:58 Completed build in 11m 43s on Mon, 20 Jul, 04:58 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4159

  5. TYPO3com voted on patch set 2 V -1 07/20/20, 17:03 Completed build in 15m 54s on Mon, 20 Jul, 05:03 PM Test Summary: 1 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4160

  6. TYPO3com voted on patch set 3 V +1 07/20/20, 17:07 Completed build in 14m 51s on Mon, 20 Jul, 05:07 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4161

  7. Daniel Goerz voted on patch set 3 V +1 CR +1 07/20/20, 17:23

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 07/21/20, 08:49

  9. Andreas Kienast voted on patch set 3 V +2 CR +2 07/21/20, 09:21

  10. Andreas Kienast merged patch set 4 07/21/20, 09:21