65061[BUGFIX] Implement Tag interface for DocBlock tags
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Nicole Hummel +1
-
Verified V +2 Done
- Benni Mack +2
- Nicole Hummel +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1117
-
Simon Gilli uploaded patch set 1 07/21/20, 09:05
-
Simon Gilli uploaded patch set 2 07/21/20, 09:06
-
TYPO3com voted on patch set 1 V -1 07/21/20, 09:16 Completed build in 11m 36s on Tue, 21 Jul, 09:16 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4169
-
Simon Gilli uploaded patch set 3 07/21/20, 09:18
-
TYPO3com voted on patch set 2 V -1 07/21/20, 09:22 Completed build in 15m 17s on Tue, 21 Jul, 09:22 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4170
-
TYPO3com voted on patch set 3 V -1 07/21/20, 09:30 Completed build in 12m 25s on Tue, 21 Jul, 09:30 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4173
-
Simon Gilli uploaded patch set 4 07/21/20, 09:38
-
TYPO3com voted on patch set 4 V -1 07/21/20, 09:49 Completed build in 11m 23s on Tue, 21 Jul, 09:49 AM Test Summary: 2287 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4175
-
Nicole Hummel commented on patch set 5 07/21/20, 09:53
Published edit on patch set 4. -
Simon Gilli commented on patch set 5 07/21/20, 10:02
Null_.php:35@nicole PhpStan complains if this method does not return a valid object... -
TYPO3com commented on patch set 4 07/21/20, 10:03 Completed build in 11m 49s on Tue, 21 Jul, 10:03 AM Test Summary: 2287 of 73432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4176
-
TYPO3com voted on patch set 5 V +1 07/21/20, 10:06 Completed build in 13m 25s on Tue, 21 Jul, 10:06 AM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4177
-
Simon Gilli commented on patch set 5 07/21/20, 10:07
Null_.php:35ReplyOk, setting void seems also to solve the issue :) -
Nicole Hummel commented on patch set 5 07/21/20, 10:07
Null_.php:35ReplyI don't think so ;-) -
Nicole Hummel voted on patch set 5 V +1 CR +1 07/21/20, 10:09
-
Benni Mack commented on patch set 5 V +2 CR +2 07/21/20, 11:34
Thanks to both of you for having a fix available so fast! -
Benni Mack merged patch set 6 07/21/20, 11:34