Review main Merged

65065[BUGFIX] Check if DOM element exists before usage

Michael Telgkamp CR +2 V +2 Easy +4 −3 updated 07/31/20, 07:27

Commit message

When collapsing or expanding all nodes of a category tree the script
tried to change attributes of non existing DOM nodes. This is not
required, so there is a check if the node exists. On node generation the
correct attributes are set for the node.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Michael Telgkamp uploaded patch set 1 07/21/20, 15:14

  2. TYPO3com voted on patch set 1 V +1 07/21/20, 15:42 Completed build in 12m 18s on Tue, 21 Jul, 03:42 PM Test Summary: 72909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4181

  3. Anja Leichsenring commented on patch set 1 CR -1 07/24/20, 05:49

    Hi Michael, thanks for that patch, but you changed the generated output file of a TypeScript file. This will not help. Please find the corresponding .ts file, make your change and then follow the contribution guide on how to compile TS to JS.
  4. Michael Telgkamp uploaded patch set 2 07/24/20, 06:36

  5. Michael Telgkamp commented on patch set 2 07/24/20, 06:38

    > Patch Set 1: Code-Review-1 > > Hi Michael, > thanks for that patch, but you changed the generated output file of a TypeScript file. This will not help. > Please find the corresponding .ts file, make your change and then follow the contribution guide on how to compile TS to JS. Hi Anja, According to my research and a confirmation of Oliver Bartsch there is no TS file for SvgTree.js. So it can only be edited in the js file itself. Also see https://review.typo3.org/c/Packages/TYPO3.CMS/+/62086/ for other similar js files edited in place.
  6. TYPO3com voted on patch set 2 V +1 07/24/20, 06:46 Completed build in 10m 42s on Fri, 24 Jul, 06:46 AM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4218

  7. Oli Bartsch uploaded patch set 3 07/24/20, 06:54

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 07/24/20, 06:55

  9. TYPO3com voted on patch set 3 V +1 07/24/20, 07:05 Completed build in 10m 52s on Fri, 24 Jul, 07:05 AM Test Summary: 72920 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4219

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 07/31/20, 07:27

  11. Andreas Kienast merged patch set 4 07/31/20, 07:27