Review main Merged

65067[BUGFIX] Deleting a localized page deletes its localized records

Christian Kuhn CR +2 V +2 Normal +210 −27 updated 07/25/20, 08:52

Commit message

This fixes an issue that has been in the core "since ever":
Have a localized page with localized records on it. If the
page localization is deleted (for instance via list module),
its localized records are NOT marked as deleted. They are
not shown anymore since the localized page record is gone,
but they're still there. If later a localization of this page
with the same sys_language_uid is created again, the records
magically reappear.
The patch changes DataHandler->deleteSpecificPage() to delete
localized records of localized pages correctly for the
sys_language_uid in question if the table is localization
aware.
An edge case within workspace is handled to suppress the
cascading delete while swapping pages.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1628

Show 23 earlier messages
  1. Christian Kuhn uploaded patch set 1 07/21/20, 17:10

  2. Christian Kuhn voted on patch set 1 CR -1 07/21/20, 17:10

  3. TYPO3com voted on patch set 1 V -1 07/21/20, 17:22 Completed build in 12m 07s on Tue, 21 Jul, 05:22 PM Test Summary: 51 of 73396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4183

  1. Christian Kuhn uploaded patch set 2 07/22/20, 13:12

  2. TYPO3com voted on patch set 2 V +1 07/22/20, 13:25 Completed build in 13m 05s on Wed, 22 Jul, 01:25 PM Test Summary: 72909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4192

  3. Benni Mack uploaded patch set 3 07/23/20, 09:25

  4. TYPO3com voted on patch set 3 V -1 07/23/20, 09:38 Completed build in 12m 52s on Thu, 23 Jul, 09:38 AM Test Summary: 3 of 73411 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4199

  5. Christian Kuhn commented on patch set 3 07/23/20, 09:46

    DataHandler.php:4930 Unresolved

    $pageLanguageId > 0 is obviously stupid here ...
  6. Christian Kuhn uploaded patch set 4 07/23/20, 09:53

  7. Christian Kuhn uploaded patch set 5 07/23/20, 09:54

  8. TYPO3com commented on patch set 4 07/23/20, 10:08 Completed build in 14m 40s on Thu, 23 Jul, 10:08 AM Test Summary: 3 of 73090 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4200

  9. TYPO3com voted on patch set 5 V -1 07/23/20, 10:10 Completed build in 15m 46s on Thu, 23 Jul, 10:10 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4201

  10. TYPO3com commented on patch set 5 07/23/20, 11:44 Completed build in 2h 05m 47s on Thu, 23 Jul, 11:44 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4201

  11. Benni Mack uploaded patch set 6 07/23/20, 13:01

  12. TYPO3com voted on patch set 6 V +1 07/23/20, 13:12 Completed build in 11m 28s on Thu, 23 Jul, 01:12 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4202

  13. Christian Kuhn uploaded patch set 7 07/23/20, 19:37

  14. Christian Kuhn updated the commit message in patch set 8 07/23/20, 19:38

  15. Christian Kuhn uploaded patch set 9 07/23/20, 19:47

  16. TYPO3com voted on patch set 7 V -1 07/23/20, 19:52 Completed build in 14m 54s on Thu, 23 Jul, 07:52 PM Test Summary: 72617 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4207

  17. Benni Mack updated the commit message in patch set 10 07/23/20, 19:53

  18. TYPO3com voted on patch set 8 V -1 07/23/20, 19:56 Completed build in 17m 08s on Thu, 23 Jul, 07:56 PM Test Summary: 72930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4208

  19. TYPO3com voted on patch set 9 V -1 07/23/20, 20:09 Completed build in 19m 57s on Thu, 23 Jul, 08:08 PM Test Summary: 72930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4210

  20. Christian Kuhn uploaded patch set 11 07/23/20, 20:11

  21. TYPO3com voted on patch set 10 V -1 07/23/20, 20:20 Completed build in 19m 25s on Thu, 23 Jul, 08:20 PM Test Summary: 72930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4213

  22. TYPO3com voted on patch set 11 V +1 07/23/20, 20:33 Completed build in 20m 53s on Thu, 23 Jul, 08:33 PM Test Summary: 72930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4215

  23. Benni Mack voted on patch set 11 V +1 CR +1 07/24/20, 20:34

  24. Andreas Kienast voted on patch set 11 V +2 CR +2 07/25/20, 08:52

  25. Andreas Kienast merged patch set 12 07/25/20, 08:52