65068[!!!][TASK] Store transOrigDiffSourceField as json string in db
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseLanguageRows.php2+3 −3
- typo3/sysext/backend/Classes/Form/FormDataCompiler.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+5 −5
- typo3/sysext/core/Documentation/Changelog/master/Breaking-91906-StoreTransOrigDiffSourceFieldAsJson.rstnew+41 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/modifyTranslatedContent.csvnew+9 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+16 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+8 −0
- typo3/sysext/install/Classes/Updates/RowUpdater/L18nDiffsourceToJsonMigration.php2new+56 −0
- typo3/sysext/install/Classes/Updates/DatabaseRowsUpdateWizard.php+2 −0
- typo3/sysext/install/Tests/Unit/Updates/RowUpdater/L18nDiffsourceToJsonMigrationTest.phpnew+124 −0
Review log 2847
Show 1122 earlier messages
-
Anja Leichsenring uploaded patch set 1 07/21/20, 19:03
-
TYPO3com voted on patch set 1 V -1 07/21/20, 19:16 Completed build in 12m 28s on Tue, 21 Jul, 07:16 PM Test Summary: 40 of 73400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4186
-
Anja Leichsenring uploaded patch set 2 07/21/20, 19:18
-
Anja Leichsenring uploaded patch set 3 07/21/20, 19:24
-
TYPO3com voted on patch set 2 V -1 07/21/20, 19:30 Completed build in 11m 29s on Tue, 21 Jul, 07:30 PM Test Summary: 40 of 73400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4187
-
TYPO3com voted on patch set 3 V -1 07/21/20, 19:35 Completed build in 10m 57s on Tue, 21 Jul, 07:35 PM Test Summary: 40 of 73400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4188
-
Anja Leichsenring uploaded patch set 4 07/21/20, 19:38
-
TYPO3com voted on patch set 4 V -1 07/21/20, 19:39 Completed build in 28s on Tue, 21 Jul, 07:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4189
-
Anja Leichsenring uploaded patch set 5 07/21/20, 19:40
-
TYPO3com voted on patch set 5 V -1 07/21/20, 19:52 Completed build in 11m 27s on Tue, 21 Jul, 07:52 PM Test Summary: 40 of 73400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4190
-
Anja Leichsenring uploaded patch set 6 07/21/20, 20:00
-
TYPO3com voted on patch set 6 V +1 07/21/20, 20:15 Completed build in 14m 27s on Tue, 21 Jul, 08:15 PM Test Summary: 72909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4191
-
Anja Leichsenring uploaded patch set 7 07/23/20, 19:44
-
TYPO3com voted on patch set 7 V -1 07/23/20, 19:59 Completed build in 14m 58s on Thu, 23 Jul, 07:59 PM Test Summary: 3 of 73411 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4209
-
Anja Leichsenring rebased onto patch set 8 07/30/20, 18:43
-
Anja Leichsenring uploaded patch set 9 07/30/20, 18:44
-
TYPO3com voted on patch set 8 V -1 07/30/20, 18:57 Completed build in 13m 16s on Thu, 30 Jul, 06:57 PM Test Summary: 3 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4317
-
TYPO3com voted on patch set 9 V -1 07/30/20, 19:00 Completed build in 14m 25s on Thu, 30 Jul, 07:00 PM Test Summary: 1 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4318
-
Anja Leichsenring uploaded patch set 10 07/30/20, 19:41
-
TYPO3com voted on patch set 10 V -1 07/30/20, 19:42 Completed build in 31s on Thu, 30 Jul, 07:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4319
-
Anja Leichsenring uploaded patch set 11 07/30/20, 19:46
-
TYPO3com voted on patch set 11 V -1 07/30/20, 19:58 Completed build in 11m 45s on Thu, 30 Jul, 07:58 PM Test Summary: 1 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4320
-
Anja Leichsenring uploaded patch set 12 07/30/20, 20:14
-
Anja Leichsenring commented on patch set 12 07/30/20, 20:15
This change is ready for review. -
Anja Leichsenring commented on patch set 13 07/30/20, 20:24
Published edit on patch set 12. -
TYPO3com voted on patch set 12 V -1 07/30/20, 20:28 Completed build in 13m 43s on Thu, 30 Jul, 08:28 PM Test Summary: 2 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4321
-
Anja Leichsenring commented on patch set 14 07/30/20, 20:30
Published edit on patch set 13. -
Anja Leichsenring commented on patch set 15 07/30/20, 20:38
Published edit on patch set 14. -
TYPO3com voted on patch set 13 V -1 07/30/20, 20:38 Completed build in 13m 40s on Thu, 30 Jul, 08:38 PM Test Summary: 1 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4322
-
TYPO3com voted on patch set 14 V -1 07/30/20, 20:44 Completed build in 13m 26s on Thu, 30 Jul, 08:44 PM Test Summary: 1 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4323
-
TYPO3com voted on patch set 15 V +1 07/30/20, 20:50 Completed build in 12m 34s on Thu, 30 Jul, 08:50 PM Test Summary: 72927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4324
-
Christian Kuhn commented on patch set 15 CR -1 07/30/20, 21:28
looks great overall! will push a patch set with minor wording improvements and stuff, though. -
Christian Kuhn uploaded patch set 16 07/30/20, 22:42
-
TYPO3com voted on patch set 16 V +1 07/30/20, 22:55 Completed build in 12m 43s on Thu, 30 Jul, 10:55 PM Test Summary: 72927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4325
-
Christian Kuhn commented on patch set 16 V -1 07/30/20, 23:19
still fiddling with details on testing - stuff does not respond in a way i'd expect it to ... -
Christian Kuhn uploaded patch set 17 07/31/20, 13:44
-
TYPO3com voted on patch set 17 V -1 07/31/20, 13:44 Completed build in 27s on Fri, 31 Jul, 01:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4332
-
Christian Kuhn uploaded patch set 18 07/31/20, 13:47
-
TYPO3com voted on patch set 18 V +1 07/31/20, 14:02 Completed build in 14m 52s on Fri, 31 Jul, 02:02 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4334
-
Christian Kuhn voted on patch set 18 V +1 CR +1 07/31/20, 14:03
-
Andreas Kienast commented on patch set 18 CR -1 07/31/20, 14:09
DatabaseLanguageRows.php:71Having a null coalesce operator to assign null makes little to no sense to me.DataHandler.php:1387null coalescing nullL18nDiffsourceToJsonMigration.php:47If $fieldContent is an object, should we update its column with a NULL value? -
Christian Kuhn uploaded patch set 19 07/31/20, 14:28
-
Christian Kuhn commented on patch set 19 07/31/20, 14:29
DatabaseLanguageRows.php:71ReplyDoneDataHandler.php:1387ReplyDoneL18nDiffsourceToJsonMigration.php:47ReplyDone -
Christian Kuhn voted on patch set 19 V +1 CR +1 07/31/20, 14:29
-
TYPO3com voted on patch set 19 V +1 07/31/20, 14:43 Completed build in 14m 02s on Fri, 31 Jul, 02:43 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4337
-
Andreas Kienast voted on patch set 19 V +2 CR +2 07/31/20, 14:50
-
Andreas Kienast merged patch set 20 07/31/20, 14:50