Review main Merged Breaking

65068[!!!][TASK] Store transOrigDiffSourceField as json string in db

Anja Leichsenring CR +2 V +2 Hard +266 −10 updated 07/31/20, 14:50

Commit message

The TCA ctrl transOrigDiffSourceField database field,
often called 'l18n_diffsource', stores information if
a default or source language record of a translated record
has been changed. This is used to hint editors with
"The record you translated from has been changed,
maybe an update of the translation is needed" in FormEngine.

The storage format of that field is a serialized PHP
string. This is no active, but a potential, general security
risk. To mitigate this, the storage format is changed to a
json string with the patch, including an install tool
database updater taking care of existing rows.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 2847

Show 1122 earlier messages
  1. Anja Leichsenring uploaded patch set 1 07/21/20, 19:03

  2. TYPO3com voted on patch set 1 V -1 07/21/20, 19:16 Completed build in 12m 28s on Tue, 21 Jul, 07:16 PM Test Summary: 40 of 73400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4186

  3. Anja Leichsenring uploaded patch set 2 07/21/20, 19:18

  4. Anja Leichsenring uploaded patch set 3 07/21/20, 19:24

  5. TYPO3com voted on patch set 2 V -1 07/21/20, 19:30 Completed build in 11m 29s on Tue, 21 Jul, 07:30 PM Test Summary: 40 of 73400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4187

  6. TYPO3com voted on patch set 3 V -1 07/21/20, 19:35 Completed build in 10m 57s on Tue, 21 Jul, 07:35 PM Test Summary: 40 of 73400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4188

  7. Anja Leichsenring uploaded patch set 4 07/21/20, 19:38

  8. TYPO3com voted on patch set 4 V -1 07/21/20, 19:39 Completed build in 28s on Tue, 21 Jul, 07:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4189

  9. Anja Leichsenring uploaded patch set 5 07/21/20, 19:40

  10. TYPO3com voted on patch set 5 V -1 07/21/20, 19:52 Completed build in 11m 27s on Tue, 21 Jul, 07:52 PM Test Summary: 40 of 73400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4190

  11. Anja Leichsenring uploaded patch set 6 07/21/20, 20:00

  12. TYPO3com voted on patch set 6 V +1 07/21/20, 20:15 Completed build in 14m 27s on Tue, 21 Jul, 08:15 PM Test Summary: 72909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4191

  13. Anja Leichsenring uploaded patch set 7 07/23/20, 19:44

  14. TYPO3com voted on patch set 7 V -1 07/23/20, 19:59 Completed build in 14m 58s on Thu, 23 Jul, 07:59 PM Test Summary: 3 of 73411 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4209

  15. Anja Leichsenring rebased onto patch set 8 07/30/20, 18:43

  16. Anja Leichsenring uploaded patch set 9 07/30/20, 18:44

  17. TYPO3com voted on patch set 8 V -1 07/30/20, 18:57 Completed build in 13m 16s on Thu, 30 Jul, 06:57 PM Test Summary: 3 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4317

  18. TYPO3com voted on patch set 9 V -1 07/30/20, 19:00 Completed build in 14m 25s on Thu, 30 Jul, 07:00 PM Test Summary: 1 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4318

  19. Anja Leichsenring uploaded patch set 10 07/30/20, 19:41

  20. TYPO3com voted on patch set 10 V -1 07/30/20, 19:42 Completed build in 31s on Thu, 30 Jul, 07:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4319

  21. Anja Leichsenring uploaded patch set 11 07/30/20, 19:46

  22. TYPO3com voted on patch set 11 V -1 07/30/20, 19:58 Completed build in 11m 45s on Thu, 30 Jul, 07:58 PM Test Summary: 1 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4320

  1. Anja Leichsenring uploaded patch set 12 07/30/20, 20:14

  2. Anja Leichsenring commented on patch set 12 07/30/20, 20:15

    This change is ready for review.
  3. Anja Leichsenring commented on patch set 13 07/30/20, 20:24

    Published edit on patch set 12.
  4. TYPO3com voted on patch set 12 V -1 07/30/20, 20:28 Completed build in 13m 43s on Thu, 30 Jul, 08:28 PM Test Summary: 2 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4321

  5. Anja Leichsenring commented on patch set 14 07/30/20, 20:30

    Published edit on patch set 13.
  6. Anja Leichsenring commented on patch set 15 07/30/20, 20:38

    Published edit on patch set 14.
  7. TYPO3com voted on patch set 13 V -1 07/30/20, 20:38 Completed build in 13m 40s on Thu, 30 Jul, 08:38 PM Test Summary: 1 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4322

  8. TYPO3com voted on patch set 14 V -1 07/30/20, 20:44 Completed build in 13m 26s on Thu, 30 Jul, 08:44 PM Test Summary: 1 of 73414 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4323

  9. TYPO3com voted on patch set 15 V +1 07/30/20, 20:50 Completed build in 12m 34s on Thu, 30 Jul, 08:50 PM Test Summary: 72927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4324

  10. Christian Kuhn commented on patch set 15 CR -1 07/30/20, 21:28

    looks great overall! will push a patch set with minor wording improvements and stuff, though.
  11. Christian Kuhn uploaded patch set 16 07/30/20, 22:42

  12. TYPO3com voted on patch set 16 V +1 07/30/20, 22:55 Completed build in 12m 43s on Thu, 30 Jul, 10:55 PM Test Summary: 72927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4325

  13. Christian Kuhn commented on patch set 16 V -1 07/30/20, 23:19

    still fiddling with details on testing - stuff does not respond in a way i'd expect it to ...
  14. Christian Kuhn uploaded patch set 17 07/31/20, 13:44

  15. TYPO3com voted on patch set 17 V -1 07/31/20, 13:44 Completed build in 27s on Fri, 31 Jul, 01:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4332

  16. Christian Kuhn uploaded patch set 18 07/31/20, 13:47

  17. TYPO3com voted on patch set 18 V +1 07/31/20, 14:02 Completed build in 14m 52s on Fri, 31 Jul, 02:02 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4334

  18. Christian Kuhn voted on patch set 18 V +1 CR +1 07/31/20, 14:03

  19. Andreas Kienast commented on patch set 18 CR -1 07/31/20, 14:09

    DatabaseLanguageRows.php:71

    Having a null coalesce operator to assign null makes little to no sense to me.

    DataHandler.php:1387

    null coalescing null

    L18nDiffsourceToJsonMigration.php:47

    If $fieldContent is an object, should we update its column with a NULL value?
  20. Christian Kuhn uploaded patch set 19 07/31/20, 14:28

  21. Christian Kuhn commented on patch set 19 07/31/20, 14:29

    DatabaseLanguageRows.php:71 Reply

    Done

    DataHandler.php:1387 Reply

    Done

    L18nDiffsourceToJsonMigration.php:47 Reply

    Done
  22. Christian Kuhn voted on patch set 19 V +1 CR +1 07/31/20, 14:29

  23. TYPO3com voted on patch set 19 V +1 07/31/20, 14:43 Completed build in 14m 02s on Fri, 31 Jul, 02:43 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4337

  24. Andreas Kienast voted on patch set 19 V +2 CR +2 07/31/20, 14:50

  25. Andreas Kienast merged patch set 20 07/31/20, 14:50