Review main Merged

65069[BUGFIX] Skip TimeTracker errors in ErrorHandler

Patrick Schriner CR +2 V +2 Easy +5 −4 updated 07/27/20, 10:58

Commit message

If adding a message to the TimeTracker (for admin panel) in the
ErrorHandler fails, that error fails silently now.

This can happen when e.g. instanstiating logging fails due to file
permission errors.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Patrick Schriner uploaded patch set 1 07/22/20, 14:41

  2. TYPO3com voted on patch set 1 V +1 07/22/20, 14:54 Completed build in 12m 25s on Wed, 22 Jul, 02:54 PM Test Summary: 72909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4193

  3. Markus Klein voted on patch set 1 CR +1 07/23/20, 06:57

  4. Benni Mack commented on patch set 1 07/23/20, 13:10

    How can I reproduce this?
  5. Benni Mack uploaded patch set 2 07/23/20, 13:15

  6. TYPO3com voted on patch set 2 V +1 07/23/20, 13:29 Completed build in 13m 34s on Thu, 23 Jul, 01:29 PM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4203

  7. Oliver Klee commented on patch set 2 07/23/20, 13:54

    Is it still related to CLI, or should we remove this reference from the commit message?
  8. Patrick Schriner uploaded patch set 3 07/23/20, 14:55

  9. Patrick Schriner commented on patch set 3 07/23/20, 14:56

    Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 07/23/20, 15:06 Completed build in 11m 35s on Thu, 23 Jul, 03:06 PM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4205

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 07/25/20, 16:29

  12. Benni Mack voted on patch set 3 V +2 CR +2 07/27/20, 10:19

  13. Benni Mack merged patch set 4 07/27/20, 10:19

  14. Tymoteusz Motylewski commented on patch set 4 07/27/20, 10:58

    Thanks a lot!